From patchwork Wed Sep 7 14:56:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Gordon X-Patchwork-Id: 9319437 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 099AF601C0 for ; Wed, 7 Sep 2016 14:56:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 04921293CA for ; Wed, 7 Sep 2016 14:56:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED3BE293CC; Wed, 7 Sep 2016 14:56:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D678B293CA for ; Wed, 7 Sep 2016 14:56:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CA6A6EAA3; Wed, 7 Sep 2016 14:56:47 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB2D46EAA3 for ; Wed, 7 Sep 2016 14:56:46 +0000 (UTC) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 07 Sep 2016 07:56:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,296,1470726000"; d="scan'208";a="165444734" Received: from dsgordon-linux2.isw.intel.com (HELO [10.102.226.88]) ([10.102.226.88]) by fmsmga004.fm.intel.com with ESMTP; 07 Sep 2016 07:56:44 -0700 To: kbuild test robot , Sagar Arun Kamble References: <201609072110.VMENzd4g%fengguang.wu@intel.com> From: Dave Gordon Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ Message-ID: Date: Wed, 7 Sep 2016 15:56:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <201609072110.VMENzd4g%fengguang.wu@intel.com> Cc: intel-gfx@lists.freedesktop.org, kbuild-all@01.org, Tom O'Rourke Subject: Re: [Intel-gfx] [PATCH v4 10/25] drm/i915/slpc: Allocate/Release/Initialize SLPC shared data X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP On 07/09/16 14:52, kbuild test robot wrote: > Hi Tom, > > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on next-20160907] > [cannot apply to v4.8-rc5] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] > [Check https://git-scm.com/docs/git-format-patch for more information] > > url: https://github.com/0day-ci/linux/commits/Sagar-Arun-Kamble/Add-support-for-GuC-based-SLPC/20160907-201335 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: i386-defconfig (attached as .config) > compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > drivers/gpu/drm/i915/intel_slpc.c: In function 'slpc_get_slice_count': >>> drivers/gpu/drm/i915/intel_slpc.c:50:37: error: 'const struct intel_device_info' has no member named 'slice_total' > slice_count = INTEL_INFO(dev_priv)->slice_total; > ^~ > > vim +50 drivers/gpu/drm/i915/intel_slpc.c > > 44 > 45 static unsigned int slpc_get_slice_count(struct drm_i915_private *dev_priv) > 46 { > 47 unsigned int slice_count = 1; > 48 > 49 if (IS_SKYLAKE(dev_priv)) > > 50 slice_count = INTEL_INFO(dev_priv)->slice_total; > 51 > 52 return slice_count; > 53 } > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx Is this the right fix? return slice_count; } .Dave. diff --git a/drivers/gpu/drm/i915/intel_slpc.c b/drivers/gpu/drm/i915/intel_slpc.c index 1a3a515..77a316e 100644 --- a/drivers/gpu/drm/i915/intel_slpc.c +++ b/drivers/gpu/drm/i915/intel_slpc.c @@ -207,7 +207,7 @@ static unsigned int slpc_get_slice_count(struct drm_i915_private *dev_priv) unsigned int slice_count = 1; if (IS_SKYLAKE(dev_priv)) - slice_count = INTEL_INFO(dev_priv)->slice_total; + slice_count = hweight8(INTEL_INFO(dev_priv)->sseu.slice_mask);