From patchwork Tue Mar 19 16:25:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yokoyama, Caz" X-Patchwork-Id: 10859995 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AF1541390 for ; Tue, 19 Mar 2019 16:25:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9647E285B5 for ; Tue, 19 Mar 2019 16:25:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8A8E729749; Tue, 19 Mar 2019 16:25:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E7B5F28816 for ; Tue, 19 Mar 2019 16:25:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 65A7C89B27; Tue, 19 Mar 2019 16:25:30 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 216A389B29 for ; Tue, 19 Mar 2019 16:25:29 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 09:25:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,498,1544515200"; d="scan'208";a="142034216" Received: from diana2.ra.intel.com ([10.23.184.226]) by FMSMGA003.fm.intel.com with ESMTP; 19 Mar 2019 09:25:28 -0700 From: Caz Yokoyama To: intel-gfx@lists.freedesktop.org Date: Tue, 19 Mar 2019 09:25:29 -0700 Message-Id: X-Mailer: git-send-email 2.17.1 Subject: [Intel-gfx] [PATCH v4 1/1] i915_pm_rpm: remove gem-execbuf-stress-extra-wait because same as gem-execbuf-stress X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Extra 5sec delay does not add any value more than gem-execbuf-stress. It waits until suspend state after a job is added by gem_execbuf(). There is no need to do more when GPU becomes suspended state. I confirm this by looking at pm_runtime_force_suspend() which exits on suspend state. Signed-off-by: Caz Yokoyama Cc: Chris Wilson Signed-off-by: Caz Yokoyama --- tests/i915/i915_pm_rpm.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c index be296f52..9a91ca0a 100644 --- a/tests/i915/i915_pm_rpm.c +++ b/tests/i915/i915_pm_rpm.c @@ -1338,12 +1338,13 @@ static void gem_execbuf_stress_subtest(int rounds, int wait_flags) for (i = 0; i < rounds; i++) { gem_execbuf(drm_fd, &execbuf); - if (wait_flags & WAIT_STATUS) + if (wait_flags & WAIT_STATUS) { + /* clean up idle work */ + igt_drop_caches_set(drm_fd, DROP_IDLE); igt_assert(wait_for_suspended()); + } if (wait_flags & WAIT_PC8_RES) igt_assert(pc8_plus_residency_changed(30)); - if (wait_flags & WAIT_EXTRA) - sleep(5); } gem_close(drm_fd, handle); @@ -2083,8 +2084,6 @@ int main(int argc, char *argv[]) gem_execbuf_stress_subtest(rounds, WAIT_STATUS); igt_subtest("gem-execbuf-stress-pc8") gem_execbuf_stress_subtest(rounds, WAIT_PC8_RES); - igt_subtest("gem-execbuf-stress-extra-wait") - gem_execbuf_stress_subtest(rounds, WAIT_STATUS | WAIT_EXTRA); /* power-wake reference tests */ igt_subtest("pm-tiling")