From patchwork Tue May 17 13:57:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 9112501 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C019ABF29F for ; Tue, 17 May 2016 13:57:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F3F022025A for ; Tue, 17 May 2016 13:57:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 29DC4201FE for ; Tue, 17 May 2016 13:57:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 56C066E3B1; Tue, 17 May 2016 13:57:33 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id E70386E3B1 for ; Tue, 17 May 2016 13:57:31 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 330FBAB5F; Tue, 17 May 2016 13:57:30 +0000 (UTC) Date: Tue, 17 May 2016 15:57:30 +0200 Message-ID: From: Takashi Iwai To: Daniel Vetter In-Reply-To: References: <1463076413-4048-1-git-send-email-imre.deak@intel.com> <20160517072048.GN27098@phenom.ffwll.local> <20160517094217.GR27098@phenom.ffwll.local> <1463480572.1241.20.camel@intel.com> <20160517111013.GA27098@phenom.ffwll.local> <1463487062.1241.34.camel@intel.com> <20160517123421.GH27098@phenom.ffwll.local> <20160517123749.GI27098@phenom.ffwll.local> <20160517123926.GJ27098@phenom.ffwll.local> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 17 May 2016 14:53:40 +0200, Takashi Iwai wrote: > > On Tue, 17 May 2016 14:39:26 +0200, > Daniel Vetter wrote: > > > > And if we _really_ want this to work at runtime too, then we need a > > system-wide nomodeset option that snd-hda can look up and act accordingly. > > Yes, this would be one option. And I noticed that this can be easily added to patch 3, just like i915 driver does: It's hackish, but should work practically enough... Takashi diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c index c9af022676c2..c48a014be7b4 100644 --- a/sound/hda/hdac_i915.c +++ b/sound/hda/hdac_i915.c @@ -361,6 +361,11 @@ int snd_hdac_i915_init(struct hdac_bus *bus) if (WARN_ON(hdac_acomp)) return -EBUSY; +#ifdef CONFIG_VGA_CONSOLE + if (vgacon_text_force()) + return -ENODEV; +#endif + if (!i915_gfx_present()) return -ENODEV;