| Message ID | 20191010225530.26400-1-sean.j.christopherson@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | x86/sgx: Fix add page bugs | expand |
On Thu, Oct 10, 2019 at 03:55:26PM -0700, Sean Christopherson wrote: > Three bug fixes in the add page flow, along with a related enhancement. > Note, patch 4/4 is effectively a revert. > > Sean Christopherson (4): > x86/sgx: Pass EADD the kernel's virtual address for the source page > x86/sgx: Check the validity of the source page address for EADD > x86/sgx: Fix EEXTEND error handling > x86/sgx: Drop mmap_sem before EEXTENDing an enclave page > > arch/x86/kernel/cpu/sgx/ioctl.c | 46 ++++++++++++++++++--------------- > 1 file changed, 25 insertions(+), 21 deletions(-) So, which one should be merged first. This or v2 of the other series. Can you send a single "for-v23 fixes" series with everything needed just so that there is no room guess work? You can call v3 of the series that you first started. You already know that I applied 1/9 and 2/9 so please don't include them. /Jarkko
On Tue, Oct 15, 2019 at 12:03:17AM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 10, 2019 at 03:55:26PM -0700, Sean Christopherson wrote: > > Three bug fixes in the add page flow, along with a related enhancement. > > Note, patch 4/4 is effectively a revert. > > > > Sean Christopherson (4): > > x86/sgx: Pass EADD the kernel's virtual address for the source page > > x86/sgx: Check the validity of the source page address for EADD > > x86/sgx: Fix EEXTEND error handling > > x86/sgx: Drop mmap_sem before EEXTENDing an enclave page > > > > arch/x86/kernel/cpu/sgx/ioctl.c | 46 ++++++++++++++++++--------------- > > 1 file changed, 25 insertions(+), 21 deletions(-) > > So, which one should be merged first. This or v2 of the other series. Shouldn't matter. > Can you send a single "for-v23 fixes" series with everything needed just > so that there is no room guess work? You can call v3 of the series that > you first started. Will do, I'll get it sent out today.
On Wed, Oct 16, 2019 at 09:39:14AM -0700, Sean Christopherson wrote: > On Tue, Oct 15, 2019 at 12:03:17AM +0300, Jarkko Sakkinen wrote: > > On Thu, Oct 10, 2019 at 03:55:26PM -0700, Sean Christopherson wrote: > > > Three bug fixes in the add page flow, along with a related enhancement. > > > Note, patch 4/4 is effectively a revert. > > > > > > Sean Christopherson (4): > > > x86/sgx: Pass EADD the kernel's virtual address for the source page > > > x86/sgx: Check the validity of the source page address for EADD > > > x86/sgx: Fix EEXTEND error handling > > > x86/sgx: Drop mmap_sem before EEXTENDing an enclave page > > > > > > arch/x86/kernel/cpu/sgx/ioctl.c | 46 ++++++++++++++++++--------------- > > > 1 file changed, 25 insertions(+), 21 deletions(-) > > > > So, which one should be merged first. This or v2 of the other series. > > Shouldn't matter. > > > Can you send a single "for-v23 fixes" series with everything needed just > > so that there is no room guess work? You can call v3 of the series that > > you first started. > > Will do, I'll get it sent out today. Thank you. I'll start to go through and merging (have the patch set now). Rather than send any new versions lets just discuss if there is something that looks weird and I'll either pick the patch unmodified or do whatever mods needs depending on the resolution. /Jarkko