[for_v23,0/5] x86/vdso: sgx: Bug fixes

Message

Sean Christopherson Oct. 11, 2019, 12:40 a.m. UTC

Fix gwo bugs that were introduced in the refactoring, and tweak the
callback prototype to make it more readable.

Please don't apply patches 3/5 -> 5/5 until Cedric has weighed in.  The
CFI patch may or may not be correct, and the prototype change is a
continuation of a discussion (sending a patch seemed like the easiest
way to move forward).

Sean Christopherson (5):
  x86/vdso: sgx: Fix misaligned stack bug when invoking exit handler
  selftests/x86/sgx: Add check to verify exit handler stack alignment
  x86/vdso: sgx: Fix unwinder support
  x86/vdso: sgx: Reorder params to callback to improve readability
  selftests/x86/sgx: Update the callbacks function parameters

 arch/x86/entry/vdso/vsgx_enter_enclave.S  | 18 ++++++++---------
 arch/x86/include/uapi/asm/sgx.h           | 10 +++++-----
 tools/testing/selftests/x86/sgx/defines.h |  1 +
 tools/testing/selftests/x86/sgx/main.c    | 24 ++++++++++++++++++-----
 4 files changed, 34 insertions(+), 19 deletions(-)

Comments

Jarkko Sakkinen Oct. 14, 2019, 9:27 p.m. UTC | #1

On Thu, Oct 10, 2019 at 05:40:54PM -0700, Sean Christopherson wrote:
> Fix gwo bugs that were introduced in the refactoring, and tweak the
> callback prototype to make it more readable.
> 
> Please don't apply patches 3/5 -> 5/5 until Cedric has weighed in.  The
> CFI patch may or may not be correct, and the prototype change is a
> continuation of a discussion (sending a patch seemed like the easiest
> way to move forward).

Cedric, Sean, thank you.

I merged everything except the selftest updates.

/Jarkko