| Message ID | 20220721194041.43970-1-kristen@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning | expand |
On 7/21/22 12:40, Kristen Carlson Accardi wrote: > OpenSSL 3.0 deprecates some of the functions used in the SGX > selftests, causing build errors on new distros. For now ignore > the warnings until support for the functions is no longer > available. Are there some better functions we should be moving to?
On Thu, 2022-07-21 at 13:02 -0700, Dave Hansen wrote: > On 7/21/22 12:40, Kristen Carlson Accardi wrote: > > OpenSSL 3.0 deprecates some of the functions used in the SGX > > selftests, causing build errors on new distros. For now ignore > > the warnings until support for the functions is no longer > > available. > > Are there some better functions we should be moving to? I looked into this actually as my first choice, but the problem I had was that the recommended new functions weren't available on other OpenSSL libraries, and we'd have to add compatibility macros and stuff, so it seemed to me that the less complicated thing to do was wait till OpenSSL 1 was just not widely deployed anymore. This strategy is also being used in other scripts in the kernel.
On 7/21/22 13:08, Kristen Carlson Accardi wrote: > On Thu, 2022-07-21 at 13:02 -0700, Dave Hansen wrote: >> On 7/21/22 12:40, Kristen Carlson Accardi wrote: >>> OpenSSL 3.0 deprecates some of the functions used in the SGX >>> selftests, causing build errors on new distros. For now ignore >>> the warnings until support for the functions is no longer >>> available. >> Are there some better functions we should be moving to? > I looked into this actually as my first choice, but the problem I had > was that the recommended new functions weren't available on other > OpenSSL libraries, and we'd have to add compatibility macros and stuff, > so it seemed to me that the less complicated thing to do was wait till > OpenSSL 1 was just not widely deployed anymore. This strategy is also > being used in other scripts in the kernel. Sounds sane to me. Thanks for the explanation.
On Thu, Jul 21, 2022 at 12:40:40PM -0700, Kristen Carlson Accardi wrote: > OpenSSL 3.0 deprecates some of the functions used in the SGX > selftests, causing build errors on new distros. For now ignore > the warnings until support for the functions is no longer > available. > > Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com> > --- > tools/testing/selftests/sgx/sigstruct.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c > index 50c5ab1aa6fa..bb191b70141a 100644 > --- a/tools/testing/selftests/sgx/sigstruct.c > +++ b/tools/testing/selftests/sgx/sigstruct.c > @@ -17,6 +17,9 @@ > #include "defines.h" > #include "main.h" > > +/* OpenSSL 3.0 has deprecated some functions. For now just ignore the warnings. */ Perhaps, even prefix with "FIXME:" prefix? > +#pragma GCC diagnostic ignored "-Wdeprecated-declarations" > + > struct q1q2_ctx { > BN_CTX *bn_ctx; > BIGNUM *m; > -- > 2.36.1 > BR, Jarkko
diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c index 50c5ab1aa6fa..bb191b70141a 100644 --- a/tools/testing/selftests/sgx/sigstruct.c +++ b/tools/testing/selftests/sgx/sigstruct.c @@ -17,6 +17,9 @@ #include "defines.h" #include "main.h" +/* OpenSSL 3.0 has deprecated some functions. For now just ignore the warnings. */ +#pragma GCC diagnostic ignored "-Wdeprecated-declarations" + struct q1q2_ctx { BN_CTX *bn_ctx; BIGNUM *m;
OpenSSL 3.0 deprecates some of the functions used in the SGX selftests, causing build errors on new distros. For now ignore the warnings until support for the functions is no longer available. Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com> --- tools/testing/selftests/sgx/sigstruct.c | 3 +++ 1 file changed, 3 insertions(+)