From patchwork Sat Sep 3 06:01:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Sakkinen X-Patchwork-Id: 12964908 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E57C38145 for ; Sat, 3 Sep 2022 06:01:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbiICGBk (ORCPT ); Sat, 3 Sep 2022 02:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231719AbiICGBj (ORCPT ); Sat, 3 Sep 2022 02:01:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E181346DAD; Fri, 2 Sep 2022 23:01:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7697160B81; Sat, 3 Sep 2022 06:01:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F621C433C1; Sat, 3 Sep 2022 06:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662184896; bh=oHvBd1ffjg/s99ZfllkCt1FwNVqrZNIyO0l4IQri3jg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m5MqTAnMXAy1pvMEXAEZdXJZtrDqtEAGcnA2BkHitBVjmmGYv0J/kQmK8CXvfyCkA hMKn02xxBOMA6z+iCB3jm4OD8zgaysiqqwDXSK/fsWgY6DU67uZcF1qa99bgtQTBtn PICT1eMQkN50Qz1Z5I14OogR0EdsfgAmMenPxkerG8tAKnD6PjjobXWlJLn5bP6Ioi 6J0AbbSJHJpke5Jo0w8JB4MNLXv+hWzPcOjoQ1k7EGPMi2q7bl6s8r3WWJ5Z1uocrg +kku1Z/BgC7nSVO1cjBblxl8445b7KRh4rABfz3TEBkdZdurEMp6bnkGfwwsFeKuCS Y6oQzErcdsYug== From: Jarkko Sakkinen To: linux-sgx@vger.kernel.org Cc: Haitao Huang , Vijay Dhanraj , Reinette Chatre , Dave Hansen , Paul Menzel , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Subject: [PATCH 2/2] x86/sgx: Handle VA page allocation failure for EAUG on PF. Date: Sat, 3 Sep 2022 09:01:08 +0300 Message-Id: <20220903060108.1709739-3-jarkko@kernel.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220903060108.1709739-1-jarkko@kernel.org> References: <20220903060108.1709739-1-jarkko@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org From: Haitao Huang VM_FAULT_NOPAGE is expected behaviour for -EBUSY failure path, when augmenting a page, as this means that the reclaimer thread has been triggered, and the intention is just to round-trip in ring-3, and retry with a new page fault. Fixes: 5a90d2c3f5ef ("x86/sgx: Support adding of pages to an initialized enclave") Signed-off-by: Haitao Huang Tested-by: Vijay Dhanraj Reviewed-by: Reinette Chatre Signed-off-by: Jarkko Sakkinen --- v4: * Remove extra white space. v3: * Added Reinette's ack. v2: * Removed reviewed-by, no other changes. --- arch/x86/kernel/cpu/sgx/encl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/sgx/encl.c b/arch/x86/kernel/cpu/sgx/encl.c index f40d64206ded..9f13d724172e 100644 --- a/arch/x86/kernel/cpu/sgx/encl.c +++ b/arch/x86/kernel/cpu/sgx/encl.c @@ -347,8 +347,11 @@ static vm_fault_t sgx_encl_eaug_page(struct vm_area_struct *vma, } va_page = sgx_encl_grow(encl, false); - if (IS_ERR(va_page)) + if (IS_ERR(va_page)) { + if (PTR_ERR(va_page) == -EBUSY) + vmret = VM_FAULT_NOPAGE; goto err_out_epc; + } if (va_page) list_add(&va_page->list, &encl->va_pages);