| Message ID | 20231213090343.1070577-1-haokexin@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | x86/sgx: Remove unnecessary try_to_freeze() | expand |
On Wed, 2023-12-13 at 17:03 +0800, Kevin Hao wrote: > A freezable kernel thread can enter frozen state during freezing by > either calling try_to_freeze() or using wait_event_freezable() and its > variants. However, there is no need to use both methods simultaneously. > > Signed-off-by: Kevin Hao <haokexin@gmail.com> > Cc: Jarkko Sakkinen <jarkko@kernel.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Borislav Petkov <bp@alien8.de> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Pavel Machek <pavel@ucw.cz> > --- > arch/x86/kernel/cpu/sgx/main.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/x86/kernel/cpu/sgx/main.c b/arch/x86/kernel/cpu/sgx/main.c > index 166692f2d501..318165b3ff78 100644 > --- a/arch/x86/kernel/cpu/sgx/main.c > +++ b/arch/x86/kernel/cpu/sgx/main.c > @@ -404,9 +404,6 @@ static int ksgxd(void *p) > WARN_ON(__sgx_sanitize_pages(&sgx_dirty_page_list)); > > while (!kthread_should_stop()) { > - if (try_to_freeze()) > - continue; > - > wait_event_freezable(ksgxd_waitq, > kthread_should_stop() || > sgx_should_reclaim(SGX_NR_HIGH_PAGES)); Reviewed-by: Kai Huang <kai.huang@intel.com>
diff --git a/arch/x86/kernel/cpu/sgx/main.c b/arch/x86/kernel/cpu/sgx/main.c index 166692f2d501..318165b3ff78 100644 --- a/arch/x86/kernel/cpu/sgx/main.c +++ b/arch/x86/kernel/cpu/sgx/main.c @@ -404,9 +404,6 @@ static int ksgxd(void *p) WARN_ON(__sgx_sanitize_pages(&sgx_dirty_page_list)); while (!kthread_should_stop()) { - if (try_to_freeze()) - continue; - wait_event_freezable(ksgxd_waitq, kthread_should_stop() || sgx_should_reclaim(SGX_NR_HIGH_PAGES));
A freezable kernel thread can enter frozen state during freezing by either calling try_to_freeze() or using wait_event_freezable() and its variants. However, there is no need to use both methods simultaneously. Signed-off-by: Kevin Hao <haokexin@gmail.com> Cc: Jarkko Sakkinen <jarkko@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Pavel Machek <pavel@ucw.cz> --- arch/x86/kernel/cpu/sgx/main.c | 3 --- 1 file changed, 3 deletions(-)