From patchwork Fri Jul 8 18:43:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dylan Yudaken X-Patchwork-Id: 12911753 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 160F3C433EF for ; Fri, 8 Jul 2022 18:44:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239626AbiGHSoY (ORCPT ); Fri, 8 Jul 2022 14:44:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239374AbiGHSoX (ORCPT ); Fri, 8 Jul 2022 14:44:23 -0400 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59E3D2DABE for ; Fri, 8 Jul 2022 11:44:22 -0700 (PDT) Received: from pps.filterd (m0109333.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 268HAVpj001971 for ; Fri, 8 Jul 2022 11:44:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=facebook; bh=IbaA6/aCRorxzxQ9WRGQtMw3AgVmYn9S1CvsZRpKYpY=; b=pxvQAlcLVmU3FEN/V4+Srj01u4ogG+uafcKXMCzQmIy2UZF7fhdfXdSIFTYTRpl7t4L2 wRF0Nj/Ub1wK5Wm7FgqXIq+w/DC67exQnvl4vNUICSClJLTGqqSJGT/xj9qMOVemb661 Z1wBnPSsdQIojD+KrBOx/AX1o1hzd/g8BB4= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3h67d26cvv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 08 Jul 2022 11:44:21 -0700 Received: from twshared22934.08.ash9.facebook.com (2620:10d:c085:108::4) by mail.thefacebook.com (2620:10d:c085:11d::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 8 Jul 2022 11:44:20 -0700 Received: by devbig038.lla2.facebook.com (Postfix, from userid 572232) id 3D1F52BA1E74; Fri, 8 Jul 2022 11:44:10 -0700 (PDT) From: Dylan Yudaken To: Jens Axboe , Pavel Begunkov , , , , , CC: , , Dylan Yudaken Subject: [PATCH for-next 0/3] io_uring: multishot recvmsg Date: Fri, 8 Jul 2022 11:43:54 -0700 Message-ID: <20220708184358.1624275-1-dylany@fb.com> X-Mailer: git-send-email 2.30.2 X-FB-Internal: Safe X-Proofpoint-GUID: LDIczZVas5p2ec4mXhEQNev2d5Mhj7ug X-Proofpoint-ORIG-GUID: LDIczZVas5p2ec4mXhEQNev2d5Mhj7ug X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-08_15,2022-07-08_01,2022-06-22_01 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org This series adds multishot support to recvmsg in io_uring. The idea is that you submit a single multishot recvmsg and then receive completions as and when data arrives. For recvmsg each completion also has control data, and this is necessarily included in the same buffer as the payload. In order to do this a new structure is used: io_uring_recvmsg_out. This specifies the length written of the name, control and payload. As well as including the flags. The layout of the buffer is
where the lengths are those specified in the original msghdr used to issue the recvmsg. I suspect this API will be the most contentious part of this series and would appreciate any comments on it. For completeness I considered having the original struct msghdr as the header, but size wise it is much bigger (72 bytes including an iovec vs 16 bytes here). Testing also showed a 1% slowdown in terms of QPS. Using a mini network tester [1] shows 14% QPS improvment using this API, however this is likely to go down to ~8% with the latest allocation cache added by Jens. I have based this on this other patch series [2]. [1]: https://github.com/DylanZA/netbench/tree/main [2]: https://lore.kernel.org/io-uring/20220708181838.1495428-1-dylany@fb.com/ Dylan Yudaken (3): net: copy from user before calling __copy_msghdr net: copy from user before calling __get_compat_msghdr io_uring: support multishot in recvmsg include/linux/socket.h | 7 +- include/net/compat.h | 5 +- include/uapi/linux/io_uring.h | 7 ++ io_uring/net.c | 195 ++++++++++++++++++++++++++++------ io_uring/net.h | 5 + net/compat.c | 39 +++---- net/socket.c | 37 +++---- 7 files changed, 215 insertions(+), 80 deletions(-) base-commit: 9802dee74e7f30ab52dc5f346373185cd860afab Acked-by: Paolo Abeni