mbox series

[RFC,liburing,v1,0/2] Fix memset() issue and simplify function naming

Message ID 20221124054345.3752171-1-ammar.faizi@intel.com (mailing list archive)
Headers show
Series Fix memset() issue and simplify function naming | expand

Message

Ammar Faizi Nov. 24, 2022, 5:46 a.m. UTC 
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Hi Jens,

On top of "remove useless branches" series. This is an RFC for
liburing nolibc. There are two patches in this series.

## Patch 1: A fix for memset() issue.

liburing has its own memset() in nolibc.c. liburing nolibc can be
linked to apps that use libc. libc has an optimized version of
memset() function. Alviro reports that he found the memset() from
liburing replaces the optimized memset() from libc when he compiled
liburing statically. When we statically link liburing, the linker will
choose the statically linked memset() over the dynamically linked
memset() that the libc provides.

Change the function name to __uring_memset() and define a macro
memset() as:

    #define memset(PTR, C, LEN) __uring_memset(PTR, C, LEN)

when CONFIG_NOLIBC is enabled. This we don't have to touch the
memset() callers.


## Patch 2: Simplify function naming.

Define malloc() and free() as __uring_malloc() and __uring_free() with
macros when CONFIG_NOLIBC is enabled. This way the callers will just
use malloc() and free() instead of uring_malloc() and uring_free().

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

Ammar Faizi (2):
  nolibc: Do not define `memset()` function in liburing
  nolibc: Simplify function naming

 src/lib.h    | 21 +++++----------------
 src/nolibc.c |  2 +-
 src/setup.c  |  6 +++---
 3 files changed, 9 insertions(+), 20 deletions(-)


base-commit: 8fc22e3b3348c0a6384ec926e0b19b6707622e58
prerequisite-patch-id: d74c76e906701902456e2b19f23c100f38f13326
prerequisite-patch-id: bd6f97f77c8f99bd374cde916f97d6223bcbfa33
prerequisite-patch-id: 7c0f399d75e806786b8a7da4d6e23bdb62876710
prerequisite-patch-id: c087dd983f1732fcb9aad8e5b20baf8b9350a935
prerequisite-patch-id: f22f5b7bf9443839ee5bdb5a162c7c7c723a87eb

Comments

Jens Axboe Nov. 25, 2022, 1:35 p.m. UTC | #1 
On Thu, 24 Nov 2022 12:46:14 +0700, Ammar Faizi wrote:
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> 
> Hi Jens,
> 
> On top of "remove useless branches" series. This is an RFC for
> liburing nolibc. There are two patches in this series.
> 
> [...]

Applied, thanks!

[1/2] nolibc: Do not define `memset()` function in liburing
      commit: db5403e58083bef48d72656d7dea53a9f7affef4
[2/2] nolibc: Simplify function naming
      commit: 0afc00bfb94121d0642c13d060b63cc07614da17

Best regards,