mbox series

[RFC,liburing,v1,0/3] Introduce '--use-libc' option

Message ID 20230622172029.726710-1-ammarfaizi2@gnuweeb.org (mailing list archive)
Headers show
Series Introduce '--use-libc' option | expand

Message

Ammar Faizi June 22, 2023, 5:20 p.m. UTC
Hi Jens,
Hi Stefan and Guillem,

This is an RFC patch series to introduce the '--use-libc' option to the
configure script.

Currently, when compiling liburing on x86, x86-64, and aarch64
architectures, the resulting binary lacks the linkage with the standard
C library (libc).

To address the concerns raised by Linux distribution package maintainers
regarding security, it is necessary to enable the linkage of libc to
liburing. Especially right now, when the security of io_uring is being
scrutinized. By incorporating the '--use-libc' option, developers can
now enhance the overall hardening of liburing by utilizing compiler
features such as the stack protector and address sanitizer.

See the following links for viewing the discussion:
Link: https://security.googleblog.com/2023/06/learnings-from-kctf-vrps-42-linux.html
Link: https://lore.kernel.org/io-uring/20230621100447.GD2667602@fedora
Link: https://lore.kernel.org/io-uring/ZJLkXC7QffsoCnpu@thunder.hadrons.org

There are three patches in this series.

  - The first patch removes the '--nolibc' option from the configure
    script as it is no longer needed. The default build on x86, x86-64,
    and aarch64 architectures is still not using libc.

  - The second patch introduces the '--use-libc' option to the configure
    script. This option enables the linkage of libc to liburing.

  - The third patch allows the use of the stack protector when building
    liburing with libc.

Please review. Thank you.

Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

Ammar Faizi (3):
  configure: Remove --nolibc option
  configure: Introduce '--use-libc' option
  src/Makefile: Allow using stack protector with libc

 configure    | 40 +++++++++++++++-------------------------
 src/Makefile |  7 +++----
 2 files changed, 18 insertions(+), 29 deletions(-)


base-commit: 49fa118c58422bad38cb96fea0f10af60691baa9

Comments

Jens Axboe June 23, 2023, 10:13 p.m. UTC | #1
On Fri, 23 Jun 2023 00:20:26 +0700, Ammar Faizi wrote:
> Hi Stefan and Guillem,
> 
> This is an RFC patch series to introduce the '--use-libc' option to the
> configure script.
> 
> Currently, when compiling liburing on x86, x86-64, and aarch64
> architectures, the resulting binary lacks the linkage with the standard
> C library (libc).
> 
> [...]

Applied, thanks!

[1/3] configure: Remove --nolibc option
      commit: 7eba81f6eb2d62d7835622267b483b95bdf0bcd5
[2/3] configure: Introduce '--use-libc' option
      commit: 151f80504d8cba262f0950b76953dd7441342163
[3/3] src/Makefile: Allow using stack protector with libc
      commit: 449ebc5a425f3a8b14c78357cbe9ab1011a797eb

Best regards,