mbox series

[0/3] trivial fixes and a cleanup of provided buffers

Message ID 20231005000531.30800-1-krisman@suse.de (mailing list archive)
Headers show
Series trivial fixes and a cleanup of provided buffers | expand

Message

Gabriel Krisman Bertazi Oct. 5, 2023, 12:05 a.m. UTC 
Jens,

I'm resubmitting the slab conversion for provided buffers with the
suggestions from Jeff (thanks!) for your consideration, and appended 2
minor fixes related to kbuf in the patchset. Since the patchset grew
from 1 to 3 patches, i pretended it is not a v2 and restart the
counting from 1.

thanks,

Gabriel Krisman Bertazi (3):
  io_uring: Fix check of BID wrapping in provided buffers
  io_uring: Allow the full buffer id space for provided buffers
  io_uring: Use slab for struct io_buffer objects

 include/linux/io_uring_types.h |  2 --
 io_uring/io_uring.c            |  4 ++-
 io_uring/io_uring.h            |  1 +
 io_uring/kbuf.c                | 58 +++++++++++++++++++---------------
 4 files changed, 37 insertions(+), 28 deletions(-)

Comments

Jens Axboe Oct. 5, 2023, 2:18 a.m. UTC | #1 
On 10/4/23 6:05 PM, Gabriel Krisman Bertazi wrote:
> Jens,
> 
> I'm resubmitting the slab conversion for provided buffers with the
> suggestions from Jeff (thanks!) for your consideration, and appended 2
> minor fixes related to kbuf in the patchset. Since the patchset grew
> from 1 to 3 patches, i pretended it is not a v2 and restart the
> counting from 1.

Thanks, this looks good. For patches 1-2, do you have test cases you
could send for liburing?
Gabriel Krisman Bertazi Oct. 5, 2023, 2:25 p.m. UTC | #2 
Jens Axboe <axboe@kernel.dk> writes:

> On 10/4/23 6:05 PM, Gabriel Krisman Bertazi wrote:
>> Jens,
>> 
>> I'm resubmitting the slab conversion for provided buffers with the
>> suggestions from Jeff (thanks!) for your consideration, and appended 2
>> minor fixes related to kbuf in the patchset. Since the patchset grew
>> from 1 to 3 patches, i pretended it is not a v2 and restart the
>> counting from 1.
>
> Thanks, this looks good. For patches 1-2, do you have test cases you
> could send for liburing?

Sure. I'll adapt them to liburing and submit shortly.
Jens Axboe Oct. 5, 2023, 2:38 p.m. UTC | #3 
On Wed, 04 Oct 2023 20:05:28 -0400, Gabriel Krisman Bertazi wrote:
> Jens,
> 
> I'm resubmitting the slab conversion for provided buffers with the
> suggestions from Jeff (thanks!) for your consideration, and appended 2
> minor fixes related to kbuf in the patchset. Since the patchset grew
> from 1 to 3 patches, i pretended it is not a v2 and restart the
> counting from 1.
> 
> [...]

Applied, thanks!

[1/3] io_uring: Fix check of BID wrapping in provided buffers
      commit: ab69838e7c75b0edb699c1a8f42752b30333c46f
[2/3] io_uring: Allow the full buffer id space for provided buffers
      commit: f74c746e476b9dad51448b9a9421aae72b60e25f
[3/3] io_uring: Use slab for struct io_buffer objects
      commit: b3a4dbc89d4021b3f90ff6a13537111a004f9d07

Best regards,