[RESEND,v2,0/9] Clean up alloc_cache allocations

Message

Gabriel Krisman Bertazi Dec. 16, 2024, 8:46 p.m. UTC

Hi, Jens, Pavel.

I sent this v2 originally during US thanksgiving week, so I'm resending
now under a more suitable time, rebased and retested on top of Jen's
for-6.14/io_uring branch.  It keeps the changes requested in v1:
renaming the allocation helper and introducing a callback instead of
zeroing the entire object, as suggested by Jens.

This was tested against liburing testsuite, with lockdep and KASAN
enabled.

For v1, please see:
  https://lore.kernel.org/io-uring/[e-mail]/T/#t

Thanks,



Gabriel Krisman Bertazi (9):
  io_uring: Fold allocation into alloc_cache helper
  io_uring: Add generic helper to allocate async data
  io_uring/futex: Allocate ifd with generic alloc_cache helper
  io_uring/poll: Allocate apoll with generic alloc_cache helper
  io_uring/uring_cmd: Allocate async data through generic helper
  io_uring/net: Allocate msghdr async data through helper
  io_uring/rw: Allocate async data through helper
  io_uring: Move old async data allocation helper to header
  io_uring/msg_ring: Drop custom destructor

 io_uring/alloc_cache.h | 13 +++++++++++++
 io_uring/futex.c       | 13 +------------
 io_uring/io_uring.c    | 17 ++---------------
 io_uring/io_uring.h    | 23 +++++++++++++++++++++++
 io_uring/msg_ring.c    |  7 -------
 io_uring/msg_ring.h    |  1 -
 io_uring/net.c         | 35 ++++++++++++++++++-----------------
 io_uring/poll.c        | 13 +++++--------
 io_uring/rw.c          | 36 ++++++++++++++++--------------------
 io_uring/timeout.c     |  5 ++---
 io_uring/uring_cmd.c   | 20 ++------------------
 io_uring/waitid.c      |  4 ++--
 12 files changed, 84 insertions(+), 103 deletions(-)

Comments

Jens Axboe Dec. 17, 2024, 12:05 a.m. UTC | #1

On Mon, 16 Dec 2024 15:46:06 -0500, Gabriel Krisman Bertazi wrote:
> I sent this v2 originally during US thanksgiving week, so I'm resending
> now under a more suitable time, rebased and retested on top of Jen's
> for-6.14/io_uring branch.  It keeps the changes requested in v1:
> renaming the allocation helper and introducing a callback instead of
> zeroing the entire object, as suggested by Jens.
> 
> This was tested against liburing testsuite, with lockdep and KASAN
> enabled.
> 
> [...]

Applied, thanks!

[1/9] io_uring: Fold allocation into alloc_cache helper
      commit: b1031968b14f83f4bb96ecc4de4f6350ae0f6dad
[2/9] io_uring: Add generic helper to allocate async data
      commit: 694022b01368387cc1ed8485e279dfe27939ee43
[3/9] io_uring/futex: Allocate ifd with generic alloc_cache helper
      commit: b42176e5055a628217ff1536111a9e2df23db835
[4/9] io_uring/poll: Allocate apoll with generic alloc_cache helper
      commit: 4cc6fd392489cd76c7aa138eddace19dbcea366e
[5/9] io_uring/uring_cmd: Allocate async data through generic helper
      commit: 02b3c515d0be7e77dd19920e30cf637e9c7a167d
[6/9] io_uring/net: Allocate msghdr async data through helper
      commit: 23d91035cafa30d186242ebdf583aa1b55f1c59e
[7/9] io_uring/rw: Allocate async data through helper
      commit: 8cf0c459993ee2911f4f01fba21b1987b102c887
[8/9] io_uring: Move old async data allocation helper to header
      commit: 6cd2993dcdc17cac5cf6b11034abc6014caab71b
[9/9] io_uring/msg_ring: Drop custom destructor
      commit: cd7f9fee711c9ca4b909ffaadcac0302358db841

Best regards,