mbox series

[0/3] typesafety improvements on io_uring-6.0

Message ID cover.1660201408.git.metze@samba.org (mailing list archive)
Headers show
Series typesafety improvements on io_uring-6.0 | expand

Message

Stefan Metzmacher Aug. 11, 2022, 7:11 a.m. UTC
Hi Jens,

with the split into individual files (which is gread)
and the introduction of the generic struct io_cmd_data,
we now have the risk do incompatible casting in
io_kiocb_to_cmd().

My patches catch casting problems with BUILD_BUG_ON() now.
While there I added missing BUILD_BUG_ON() checks
for new io_uring_sqe fields.

Stefan Metzmacher (3):
  io_uring: consistently make use of io_notif_to_data()
  io_uring: make io_kiocb_to_cmd() typesafe
  io_uring: add missing BUILD_BUG_ON() checks for new io_uring_sqe
    fields

 include/linux/io_uring_types.h |  9 +++++++-
 io_uring/advise.c              |  8 +++----
 io_uring/cancel.c              |  4 ++--
 io_uring/epoll.c               |  4 ++--
 io_uring/fs.c                  | 28 +++++++++++------------
 io_uring/io_uring.c            | 19 ++++++++++++---
 io_uring/kbuf.c                |  8 +++----
 io_uring/msg_ring.c            |  8 +++----
 io_uring/net.c                 | 42 +++++++++++++++++-----------------
 io_uring/notif.c               |  4 +---
 io_uring/notif.h               |  2 +-
 io_uring/openclose.c           | 16 ++++++-------
 io_uring/poll.c                | 16 ++++++-------
 io_uring/rsrc.c                | 10 ++++----
 io_uring/rw.c                  | 28 +++++++++++------------
 io_uring/splice.c              |  8 +++----
 io_uring/statx.c               |  6 ++---
 io_uring/sync.c                | 12 +++++-----
 io_uring/timeout.c             | 26 ++++++++++-----------
 io_uring/uring_cmd.c           | 11 +++++----
 io_uring/xattr.c               | 18 +++++++--------
 21 files changed, 154 insertions(+), 133 deletions(-)

Comments

Jens Axboe Aug. 11, 2022, 3:38 p.m. UTC | #1
On Thu, 11 Aug 2022 09:11:13 +0200, Stefan Metzmacher wrote:
> with the split into individual files (which is gread)
> and the introduction of the generic struct io_cmd_data,
> we now have the risk do incompatible casting in
> io_kiocb_to_cmd().
> 
> My patches catch casting problems with BUILD_BUG_ON() now.
> While there I added missing BUILD_BUG_ON() checks
> for new io_uring_sqe fields.
> 
> [...]

Applied, thanks!

[1/3] io_uring: consistently make use of io_notif_to_data()
      commit: 3608c38ea378cb7bb2d43ebe43c468c7be58b83a
[2/3] io_uring: make io_kiocb_to_cmd() typesafe
      commit: 28789defa868b7b731ed73cfd7e0c0bfcd901de7
[3/3] io_uring: add missing BUILD_BUG_ON() checks for new io_uring_sqe fields
      commit: 4167efe6463b09505112b6dc2c30b8ac68fcf348

Best regards,