From patchwork Fri Aug 12 02:00:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang chunchao X-Patchwork-Id: 12941864 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B63BFC25B06 for ; Fri, 12 Aug 2022 02:00:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236513AbiHLCAR (ORCPT ); Thu, 11 Aug 2022 22:00:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236439AbiHLCAQ (ORCPT ); Thu, 11 Aug 2022 22:00:16 -0400 Received: from mail.nfschina.com (unknown [IPv6:2400:dd01:100f:2:72e2:84ff:fe10:5f45]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 09CD7BAE; Thu, 11 Aug 2022 19:00:14 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id F19D81E80D0E; Fri, 12 Aug 2022 09:58:04 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UNQzZ4lInD8g; Fri, 12 Aug 2022 09:58:02 +0800 (CST) Received: from localhost.localdomain.localdomain (unknown [219.141.250.2]) (Authenticated sender: chunchao@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id 3C11F1E80CB7; Fri, 12 Aug 2022 09:58:02 +0800 (CST) From: Zhang chunchao To: axboe@kernel.dk, asml.silence@gmail.com Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@nfschina.com, Zhang chunchao Subject: [PATCH] io_uring: Optimizing return value Date: Fri, 12 Aug 2022 10:00:00 +0800 Message-Id: <20220812020000.3720-1-chunchao@nfschina.com> X-Mailer: git-send-email 2.18.2 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Delete return value ret Initialize assignment, change return value ret to EOPNOTSUPP when IO_IS_URING_FOPS failed. Signed-off-by: Zhang chunchao --- io_uring/io_uring.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index b54218da075c..1b56f3d1a47b 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -3859,16 +3859,17 @@ SYSCALL_DEFINE4(io_uring_register, unsigned int, fd, unsigned int, opcode, void __user *, arg, unsigned int, nr_args) { struct io_ring_ctx *ctx; - long ret = -EBADF; + long ret; struct fd f; f = fdget(fd); if (!f.file) return -EBADF; - ret = -EOPNOTSUPP; - if (!io_is_uring_fops(f.file)) + if (!io_is_uring_fops(f.file)) { + ret = -EOPNOTSUPP; goto out_fput; + } ctx = f.file->private_data;