| Message ID | 20220905020436.51894-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | io_uring/notif: Remove the unused function io_notif_complete() | expand |
On 9/5/22 03:04, Jiapeng Chong wrote: > The function io_notif_complete() is defined in the notif.c file, but not > called elsewhere, so delete this unused function. Yep, forgot to kill it, LGTM Reviewed-by: Pavel Begunkov <asml.silence@gmail.com> > io_uring/notif.c:24:20: warning: unused function 'io_notif_complete' [-Wunused-function]. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2047 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > io_uring/notif.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/io_uring/notif.c b/io_uring/notif.c > index 96f076b175e0..1a7abd7e5ca5 100644 > --- a/io_uring/notif.c > +++ b/io_uring/notif.c > @@ -21,14 +21,6 @@ static void __io_notif_complete_tw(struct io_kiocb *notif, bool *locked) > io_req_task_complete(notif, locked); > } > > -static inline void io_notif_complete(struct io_kiocb *notif) > - __must_hold(¬if->ctx->uring_lock) > -{ > - bool locked = true; > - > - __io_notif_complete_tw(notif, &locked); > -} > - > static void io_uring_tx_zerocopy_callback(struct sk_buff *skb, > struct ubuf_info *uarg, > bool success)
On Mon, 5 Sep 2022 10:04:36 +0800, Jiapeng Chong wrote: > The function io_notif_complete() is defined in the notif.c file, but not > called elsewhere, so delete this unused function. > > io_uring/notif.c:24:20: warning: unused function 'io_notif_complete' [-Wunused-function]. > > Applied, thanks! [1/1] io_uring/notif: Remove the unused function io_notif_complete() commit: 4fa07edbb7eacfb56b3aa64f590e9f38e7f1042c Best regards,
diff --git a/io_uring/notif.c b/io_uring/notif.c index 96f076b175e0..1a7abd7e5ca5 100644 --- a/io_uring/notif.c +++ b/io_uring/notif.c @@ -21,14 +21,6 @@ static void __io_notif_complete_tw(struct io_kiocb *notif, bool *locked) io_req_task_complete(notif, locked); } -static inline void io_notif_complete(struct io_kiocb *notif) - __must_hold(¬if->ctx->uring_lock) -{ - bool locked = true; - - __io_notif_complete_tw(notif, &locked); -} - static void io_uring_tx_zerocopy_callback(struct sk_buff *skb, struct ubuf_info *uarg, bool success)
The function io_notif_complete() is defined in the notif.c file, but not called elsewhere, so delete this unused function. io_uring/notif.c:24:20: warning: unused function 'io_notif_complete' [-Wunused-function]. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2047 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- io_uring/notif.c | 8 -------- 1 file changed, 8 deletions(-)