| Message ID | 20221115070900.1788837-3-shr@devkernel.io (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | io_uring: add napi busy polling support | expand |
On 11/15/22 12:08 AM, Stefan Roesch wrote: > This adds an api to register the busy poll timeout from liburing. To be > able to use this functionality, the corresponding liburing patch is needed. Kind of related to the previous question, but I think we should just add a single REGISTER opcode for this, and define a struct with the delay setting. Add necessary padding for that, check padding for non-zero and EINVAL if set. Then patch 3 can just add that struct field. The IORING_REGISTER_NAPI can then also return the current settings by just copying it back. That makes it a get/set API as well. Patch 1 would be unaffected, this just changes patch 2+3 for the io_uring API.
diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h index 2df3225b562f..9b5c1df0d1d8 100644 --- a/include/uapi/linux/io_uring.h +++ b/include/uapi/linux/io_uring.h @@ -490,6 +490,9 @@ enum { /* register a range of fixed file slots for automatic slot allocation */ IORING_REGISTER_FILE_ALLOC_RANGE = 25, + /* set/clear busy poll timeout */ + IORING_REGISTER_NAPI_BUSY_POLL_TIMEOUT = 27, + /* this goes last */ IORING_REGISTER_LAST }; diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 4f432694cbed..f6c9c9cbe0f8 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -4122,6 +4122,16 @@ static __cold int io_register_iowq_max_workers(struct io_ring_ctx *ctx, return ret; } +static int io_register_napi_busy_poll_timeout(struct io_ring_ctx *ctx, unsigned int to) +{ +#ifdef CONFIG_NET_RX_BUSY_POLL + WRITE_ONCE(ctx->napi_busy_poll_to, to); + return 0; +#else + return -EINVAL; +#endif +} + static int __io_uring_register(struct io_ring_ctx *ctx, unsigned opcode, void __user *arg, unsigned nr_args) __releases(ctx->uring_lock) @@ -4282,6 +4292,12 @@ static int __io_uring_register(struct io_ring_ctx *ctx, unsigned opcode, break; ret = io_register_file_alloc_range(ctx, arg); break; + case IORING_REGISTER_NAPI_BUSY_POLL_TIMEOUT: + ret = -EINVAL; + if (arg || !nr_args) + break; + ret = io_register_napi_busy_poll_timeout(ctx, nr_args); + break; default: ret = -EINVAL; break;
This adds an api to register the busy poll timeout from liburing. To be able to use this functionality, the corresponding liburing patch is needed. Signed-off-by: Stefan Roesch <shr@devkernel.io> --- include/uapi/linux/io_uring.h | 3 +++ io_uring/io_uring.c | 16 ++++++++++++++++ 2 files changed, 19 insertions(+)