From patchwork Thu Nov 24 08:01:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ammar Faizi X-Patchwork-Id: 13054657 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3B44C433FE for ; Thu, 24 Nov 2022 08:02:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbiKXIBz (ORCPT ); Thu, 24 Nov 2022 03:01:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbiKXIBx (ORCPT ); Thu, 24 Nov 2022 03:01:53 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7144CC17E for ; Thu, 24 Nov 2022 00:01:52 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.240]) by gnuweeb.org (Postfix) with ESMTPSA id C4C3081352; Thu, 24 Nov 2022 08:01:48 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1669276912; bh=XmqNASuTOUfQYepVgge6guKR+RUrIm89rG2vy1bPaFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JDZhfJJv4qlvI9QyXxIKxjXgZIP63RVaE4tHZYt66LnAtO6CUQmagaNU2vHZo7jCv J2jY7VCln8slp683tAYHxnd4iITdgBmM2zwW2eryOKeYFj87YB0gzfyY08yCvMe7a1 5y7D6qG89OiSuHyRG167Yj7yDn8IB8ne8XcmEUBdFr9Ysiv3/XywSkibEq7I/Mh2kr fYtC0/76Tv5nhhqKItn/DTA1CW5mYTRsJSgjh2ZkcLEBP5dQNMp81DKk9zd60AD/x4 j5zFX9Pvcf25IHmI3UaioKgUvkwpdeTVa8FN33QK38rGL+9zKfT8LSguyhBcFMSDSb PPl/sQ70QwYrg== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Pavel Begunkov , io-uring Mailing List , GNU/Weeb Mailing List , Gilang Fachrezy , Muhammad Rizki , Alviro Iskandar Setiawan , VNLX Kernel Department Subject: [PATCH liburing v1 7/7] github: Add `-Wmissing-prototypes` for GitHub CI bot Date: Thu, 24 Nov 2022 15:01:02 +0700 Message-Id: <20221124075846.3784701-8-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221124075846.3784701-1-ammar.faizi@intel.com> References: <20221124075846.3784701-1-ammar.faizi@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org From: Ammar Faizi Using -Wmissing-prototypes ensures we mark functions and variables as static if we don't use them outside the translation unit. This enforcement is good because it hints the compiler to do escape analysis and optimization better. Signed-off-by: Ammar Faizi --- .github/workflows/build.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b0e669d..4c0bd26 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -26,7 +26,8 @@ jobs: cxx_pkg: clang cc: clang cxx: clang++ - extra_flags: -Wshorten-64-to-32 + liburing_extra_flags: -Wshorten-64-to-32 + extra_flags: -Wmissing-prototypes # x86 (32-bit) gcc - arch: i686 @@ -85,10 +86,10 @@ jobs: cxx: mips-linux-gnu-g++ env: - FLAGS: -g -O3 -Wall -Wextra -Werror + FLAGS: -g -O3 -Wall -Wextra -Werror ${{matrix.extra_flags}} # Flags for building sources in src/ dir only. - LIBURING_CFLAGS: ${{matrix.extra_flags}} + LIBURING_CFLAGS: ${{matrix.liburing_extra_flags}} steps: - name: Checkout source