| Message ID | 7404b4a696f64e33e5ef3c5bd3754d4f26d13e50.1664887093.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] io_uring: Add missing inline to io_uring_cmd_import_fixed() dummy | expand |
On 10/4/22 6:39 AM, Geert Uytterhoeven wrote: > If CONFIG_IO_URING is not set: > > include/linux/io_uring.h:65:12: error: ‘io_uring_cmd_import_fixed’ defined but not used [-Werror=unused-function] > 65 | static int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw, > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > Fix this by adding the missing "inline" keyword. Thanks Geert, I'll get this added.
On Tue, 4 Oct 2022 14:39:10 +0200, Geert Uytterhoeven wrote: > If CONFIG_IO_URING is not set: > > include/linux/io_uring.h:65:12: error: ‘io_uring_cmd_import_fixed’ defined but not used [-Werror=unused-function] > 65 | static int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw, > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > Fix this by adding the missing "inline" keyword. > > [...] Applied, thanks! [1/1] io_uring: Add missing inline to io_uring_cmd_import_fixed() dummy (no commit info) Best regards,
diff --git a/include/linux/io_uring.h b/include/linux/io_uring.h index e10c5cc810827ab8..43bc8a2edccf5aa3 100644 --- a/include/linux/io_uring.h +++ b/include/linux/io_uring.h @@ -62,7 +62,7 @@ static inline void io_uring_free(struct task_struct *tsk) __io_uring_free(tsk); } #else -static int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw, +static inline int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw, struct iov_iter *iter, void *ioucmd) { return -EOPNOTSUPP;
If CONFIG_IO_URING is not set: include/linux/io_uring.h:65:12: error: ‘io_uring_cmd_import_fixed’ defined but not used [-Werror=unused-function] 65 | static int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw, | ^~~~~~~~~~~~~~~~~~~~~~~~~ Fix this by adding the missing "inline" keyword. Fixes: a9216fac3ed8819c ("io_uring: add io_uring_cmd_import_fixed") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- include/linux/io_uring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)