From patchwork Tue Oct 15 11:34:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Gomez via B4 Relay X-Patchwork-Id: 13836232 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A2DD1E907D for ; Tue, 15 Oct 2024 11:35:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728992111; cv=none; b=gt3/WUiUdVFgtzQ4CdkPafYsjuUCOHG9YkNCtsibPKLKkAFJZeohSxFMmXPiSpeBdO0kb+JW418056k0Y7gw13c8tpAJt0ZwlEF1weEFGVEgMgj5FFwtnDZOkqJNyqP412XkgXnIT7xWH1fPV0wDbXp7WKCFlvRD98Vu0kYCNWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728992111; c=relaxed/simple; bh=lv/WiPJ6Ce5YmMfyhTVTNymhet1YlWoyOQNGAF9WXGs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=W9fW8DMnGrEQNPlKI2gSyvRhVR1HCNPZmJZ+cGngTEu9OvsH0DIjpecM5B218r46GXaLtoyjih2LA+R3EfRyOEkqR/vci5AxeLTfKOhGPD93cfmh00mSPHlC72gJm436r/gWCSb+EC7gZMbQsYQxrZ2nUAZxfZfBPwgXOb7Ca5Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VQsmPeck; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VQsmPeck" Received: by smtp.kernel.org (Postfix) with ESMTPS id AF4C5C4CED2; Tue, 15 Oct 2024 11:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728992110; bh=lv/WiPJ6Ce5YmMfyhTVTNymhet1YlWoyOQNGAF9WXGs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=VQsmPecks4hUCle3NL+EB9rJ4J3DPQmiV8rBg+oRpJDL3wgMbWQyaRM40sjpNhtvq o0PbM3Z2PqrmSbGOu6dM0V6yWiJ8dZHwJBtVCFJ673AdtN8pbtuBEXEvIC0oDmVZ2x IYWWt7G+ldhI+ORlauPfbqCHEmeE9VJU8c4rTMbFI8hiwjS1yRr4lt7x6omm/XQTtH xKGdm+PEbD+/aDGrDu9LZInjxCMug1msslJFiyPIQZEzst5PNGx3+dUK18+nYPlp5g ppVfw0vO5y6UqV0d9nwep1TxkL7qkIhly5mFd5klHPki7XoEXVK4usQ680nqnfMp7a 4wItr0qhi7pEQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3461CFC294; Tue, 15 Oct 2024 11:35:10 +0000 (UTC) From: Daniel Gomez via B4 Relay Date: Tue, 15 Oct 2024 13:34:54 +0200 Subject: [PATCH 4/5] guestfs: bringup: fix user check when debug Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241015-bringup-guestfs-debug-v1-4-bd74c0c31412@samsung.com> References: <20241015-bringup-guestfs-debug-v1-0-bd74c0c31412@samsung.com> In-Reply-To: <20241015-bringup-guestfs-debug-v1-0-bd74c0c31412@samsung.com> To: kdevops@lists.linux.dev, Luis Chamberlain Cc: "Daniel Gomez (Samsung)" , Daniel Gomez X-Mailer: b4 0.15-dev-2a633 X-Developer-Signature: v=1; a=ed25519-sha256; t=1728992109; l=792; i=da.gomez@samsung.com; s=20240621; h=from:subject:message-id; bh=v9hvEPJijMSXr0qDwFBjQSGQk2G5W+FZoAA2dzyx9Og=; b=M6rDRkrLXvypRZjVY5Kfin5tW8SsT1PdsmSP4rg/OpIzsUVbnOkXPsv8RpNWURctgWLqWdiup +0uBi1fOk8hBmI7RVbGGJr5gtrEwlWnGhdkUKsGXmoElc45B2GmIoXO X-Developer-Key: i=da.gomez@samsung.com; a=ed25519; pk=BqYk31UHkmv0WZShES6pIZcdmPPGay5LbzifAdZ2Ia4= X-Endpoint-Received: by B4 Relay for da.gomez@samsung.com/20240621 with auth_id=175 X-Original-From: Daniel Gomez Reply-To: da.gomez@samsung.com From: Daniel Gomez Replace id -u with getent to check if the user exists. Avoids id: ‘kdevops’: no such user. Signed-off-by: Daniel Gomez --- scripts/bringup_guestfs.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/bringup_guestfs.sh b/scripts/bringup_guestfs.sh index 19117e9a6ab55cfbe7c79f17e4a9b736edeb2607..54d8d92dcf2ff5f1de2099cbff785866c9f1c27d 100755 --- a/scripts/bringup_guestfs.sh +++ b/scripts/bringup_guestfs.sh @@ -200,8 +200,7 @@ _EOT pre_install_customizations() { KDEVOPS_UID="" - id -u kdevops 2>&1 > /dev/null - if [ $? -eq 0 ]; then + if getent passwd kdevops > /dev/null 2>&1; then KDEVOPS_UID="-u `id -u kdevops`" fi if echo $OS_VERSION | grep -qE "^(rhel|fedora|centos)"; then