diff mbox series

[07/18] KEYS: remove redundant memset

Message ID 160751611918.1238376.7060458630378643472.stgit@warthog.procyon.org.uk (mailing list archive)
State New
Headers show
Series keys: Miscellaneous fixes | expand

Commit Message

David Howells Dec. 9, 2020, 12:15 p.m. UTC 
From: Tom Rix <trix@redhat.com>

Reviewing use of memset in keyctrl_pkey.c

keyctl_pkey_params_get prologue code to set params up

	memset(params, 0, sizeof(*params));
	params->encoding = "raw";

keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.

So remove the prologue.

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 security/keys/keyctl_pkey.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Ben Boeckel Dec. 9, 2020, 7:07 p.m. UTC | #1 
On Wed, Dec 09, 2020 at 12:15:19 +0000, David Howells wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Reviewing use of memset in keyctrl_pkey.c

Typo: `keyctl_pkey.c`

--Ben
David Howells Dec. 10, 2020, 9:21 a.m. UTC | #2 
Ben Boeckel <me@benboeckel.net> wrote:

> > Reviewing use of memset in keyctrl_pkey.c
> 
> Typo: `keyctl_pkey.c`

Fixed, thanks.

David
diff mbox series

Patch

diff --git a/security/keys/keyctl_pkey.c b/security/keys/keyctl_pkey.c
index 931d8dfb4a7f..5de0d599a274 100644
--- a/security/keys/keyctl_pkey.c
+++ b/security/keys/keyctl_pkey.c
@@ -166,8 +166,6 @@  long keyctl_pkey_query(key_serial_t id,
 	struct kernel_pkey_query res;
 	long ret;
 
-	memset(&params, 0, sizeof(params));
-
 	ret = keyctl_pkey_params_get(id, _info, &params);
 	if (ret < 0)
 		goto error;