From patchwork Fri Feb 17 20:14:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robbie Harwood X-Patchwork-Id: 13145237 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02446C05027 for ; Fri, 17 Feb 2023 20:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229561AbjBQUPm (ORCPT ); Fri, 17 Feb 2023 15:15:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjBQUPk (ORCPT ); Fri, 17 Feb 2023 15:15:40 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C434B5CF25 for ; Fri, 17 Feb 2023 12:14:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676664892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xn7arF7NMqBwgWPpnjM4u1fv/6Qauysc+8RWFGLg5fo=; b=RzcgGbtVCbeJCBoEGWb7FN4S8N7vQQpprwEwsEQki0py0EZ/psLqwd3Md2Sz4DDQo+KTbZ 4FBi1Sic2QdTQgncNa+SXC7WRTIRFY5h9K2fKvl2p2imcKkO1Ctk02ENV5DYVqnPeFOSLA YlXlzVYoEfcpZRE7YXVxgKLl4a/80MI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-426-v_MoEudNOhiMmYYULtA6tA-1; Fri, 17 Feb 2023 15:14:50 -0500 X-MC-Unique: v_MoEudNOhiMmYYULtA6tA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3BB12101A52E for ; Fri, 17 Feb 2023 20:14:50 +0000 (UTC) Received: from eesha.redhat.com (unknown [10.22.18.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B57BC15BA0; Fri, 17 Feb 2023 20:14:50 +0000 (UTC) From: Robbie Harwood To: keyrings@vger.kernel.org, David Howells Cc: Robbie Harwood Subject: [PATCH v1 1/2] verify_pefile: relax wrapper length check Date: Fri, 17 Feb 2023 15:14:34 -0500 Message-Id: <20230217201435.39784-2-rharwood@redhat.com> In-Reply-To: <20230217201435.39784-1-rharwood@redhat.com> References: <20230217201435.39784-1-rharwood@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org The PE Format Specification (section "The Attribute Certificate Table (Image Only)") states that `dwLength` is to be rounded up to 8-byte alignment when used for traversal. Therefore, the field is not required to be an 8-byte multiple in the first place. Accordingly, pesign has not performed this alignment since version 0.110. This causes kexec failure on pesign'd binaries with "PEFILE: Signature wrapper len wrong". Update the comment and relax the check. See-also: https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#the-attribute-certificate-table-image-only See-also: https://github.com/rhboot/pesign Signed-off-by: Robbie Harwood Acked-by: David Howells --- crypto/asymmetric_keys/verify_pefile.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c index 7553ab18db89..fe1bb374239d 100644 --- a/crypto/asymmetric_keys/verify_pefile.c +++ b/crypto/asymmetric_keys/verify_pefile.c @@ -135,11 +135,15 @@ static int pefile_strip_sig_wrapper(const void *pebuf, pr_debug("sig wrapper = { %x, %x, %x }\n", wrapper.length, wrapper.revision, wrapper.cert_type); - /* Both pesign and sbsign round up the length of certificate table - * (in optional header data directories) to 8 byte alignment. + /* sbsign rounds up the length of certificate table (in optional + * header data directories) to 8 byte alignment. However, the PE + * specification states that while entries are 8-byte aligned, this is + * not included in their length, and as a result, pesign has not + * rounded up since 0.110. */ - if (round_up(wrapper.length, 8) != ctx->sig_len) { - pr_debug("Signature wrapper len wrong\n"); + if (wrapper.length > ctx->sig_len) { + pr_debug("Signature wrapper bigger than sig len (%x > %x)\n", + ctx->sig_len, wrapper.length); return -ELIBBAD; } if (wrapper.revision != WIN_CERT_REVISION_2_0) {