| Message ID | 20240606-md-trusted-v3-1-42716f15e66e@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | KEYS: add missing MODULE_DESCRIPTION() macros | expand |
On Fri Jun 7, 2024 at 4:47 AM EEST, Jeff Johnson wrote: > kbuild reports: > > WARNING: modpost: missing MODULE_DESCRIPTION() in security/keys/trusted-keys/trusted.o > > Add the missing MODULE_DESCRIPTION() macro invocation. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > security/keys/trusted-keys/trusted_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/security/keys/trusted-keys/trusted_core.c b/security/keys/trusted-keys/trusted_core.c > index 5113aeae5628..e2d9644efde1 100644 > --- a/security/keys/trusted-keys/trusted_core.c > +++ b/security/keys/trusted-keys/trusted_core.c > @@ -395,4 +395,5 @@ static void __exit cleanup_trusted(void) > late_initcall(init_trusted); > module_exit(cleanup_trusted); > > +MODULE_DESCRIPTION("Trusted Key type"); > MODULE_LICENSE("GPL"); Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
On Wed, Jun 19, 2024 at 8:19 PM Jarkko Sakkinen <jarkko@kernel.org> wrote: > On Fri Jun 7, 2024 at 4:47 AM EEST, Jeff Johnson wrote: > > kbuild reports: > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in security/keys/trusted-keys/trusted.o > > > > Add the missing MODULE_DESCRIPTION() macro invocation. > > > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > --- > > security/keys/trusted-keys/trusted_core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/security/keys/trusted-keys/trusted_core.c b/security/keys/trusted-keys/trusted_core.c > > index 5113aeae5628..e2d9644efde1 100644 > > --- a/security/keys/trusted-keys/trusted_core.c > > +++ b/security/keys/trusted-keys/trusted_core.c > > @@ -395,4 +395,5 @@ static void __exit cleanup_trusted(void) > > late_initcall(init_trusted); > > module_exit(cleanup_trusted); > > > > +MODULE_DESCRIPTION("Trusted Key type"); > > MODULE_LICENSE("GPL"); > > Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Are you planning on taking these patches Jarkko?
On Thu, 2024-06-20 at 12:54 -0400, Paul Moore wrote: > On Wed, Jun 19, 2024 at 8:19 PM Jarkko Sakkinen <jarkko@kernel.org> wrote: > > On Fri Jun 7, 2024 at 4:47 AM EEST, Jeff Johnson wrote: > > > kbuild reports: > > > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in security/keys/trusted-keys/trusted.o > > > > > > Add the missing MODULE_DESCRIPTION() macro invocation. > > > > > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > > --- > > > security/keys/trusted-keys/trusted_core.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/security/keys/trusted-keys/trusted_core.c b/security/keys/trusted- > > > keys/trusted_core.c > > > index 5113aeae5628..e2d9644efde1 100644 > > > --- a/security/keys/trusted-keys/trusted_core.c > > > +++ b/security/keys/trusted-keys/trusted_core.c > > > @@ -395,4 +395,5 @@ static void __exit cleanup_trusted(void) > > > late_initcall(init_trusted); > > > module_exit(cleanup_trusted); > > > > > > +MODULE_DESCRIPTION("Trusted Key type"); > > > MODULE_LICENSE("GPL"); > > > > Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> > > Are you planning on taking these patches Jarkko? Hi, both are now applied. Except slow phase this month as I'm on holiday. I'll take care of v6.11 PR's. BR, Jarkko
diff --git a/security/keys/trusted-keys/trusted_core.c b/security/keys/trusted-keys/trusted_core.c index 5113aeae5628..e2d9644efde1 100644 --- a/security/keys/trusted-keys/trusted_core.c +++ b/security/keys/trusted-keys/trusted_core.c @@ -395,4 +395,5 @@ static void __exit cleanup_trusted(void) late_initcall(init_trusted); module_exit(cleanup_trusted); +MODULE_DESCRIPTION("Trusted Key type"); MODULE_LICENSE("GPL");
kbuild reports: WARNING: modpost: missing MODULE_DESCRIPTION() in security/keys/trusted-keys/trusted.o Add the missing MODULE_DESCRIPTION() macro invocation. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- security/keys/trusted-keys/trusted_core.c | 1 + 1 file changed, 1 insertion(+)