| Message ID | 1538123582-17442-1-git-send-email-thuth@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Compile with -Wmissing-prototypes and -Wstrict-prototypes | expand |
On 28/09/2018 10:32, Thomas Huth wrote: > Compiling with -Wmissing-prototypes and -Wstrict-prototypes should help > us to make sure that implementations always match the prototypes in > the headers, so we hopefully can avoid some bugs in the future this way. > > Thomas Huth (4): > x86: Declare local functions as "static" and specify argument types > x86: Add missing prototypes and mark more local functions as static > s390x: Make code compilable with -Wmissing-prototypes and > -Wstrict-prototypes > Makefile: Compile with -Wmissing-prototypes and -Wstrict-prototypes > > Makefile | 1 + > lib/s390x/asm/float.h | 2 +- > lib/s390x/mmu.c | 1 + > lib/x86/desc.c | 5 +++++ > lib/x86/setup.c | 4 +++- > x86/cmpxchg8b.c | 2 +- > x86/eventinj.c | 6 ++++-- > x86/kvmclock.c | 11 ++++++----- > x86/pku.c | 3 ++- > x86/smap.c | 1 + > x86/taskswitch2.c | 12 +++++++----- > x86/tsc.c | 4 ++-- > x86/umip.c | 6 +++--- > x86/vmx.c | 6 +++--- > 14 files changed, 40 insertions(+), 24 deletions(-) > Applied, thanks. Paolo
Compiling with -Wmissing-prototypes and -Wstrict-prototypes should help us to make sure that implementations always match the prototypes in the headers, so we hopefully can avoid some bugs in the future this way. Thomas Huth (4): x86: Declare local functions as "static" and specify argument types x86: Add missing prototypes and mark more local functions as static s390x: Make code compilable with -Wmissing-prototypes and -Wstrict-prototypes Makefile: Compile with -Wmissing-prototypes and -Wstrict-prototypes Makefile | 1 + lib/s390x/asm/float.h | 2 +- lib/s390x/mmu.c | 1 + lib/x86/desc.c | 5 +++++ lib/x86/setup.c | 4 +++- x86/cmpxchg8b.c | 2 +- x86/eventinj.c | 6 ++++-- x86/kvmclock.c | 11 ++++++----- x86/pku.c | 3 ++- x86/smap.c | 1 + x86/taskswitch2.c | 12 +++++++----- x86/tsc.c | 4 ++-- x86/umip.c | 6 +++--- x86/vmx.c | 6 +++--- 14 files changed, 40 insertions(+), 24 deletions(-)