mbox series

[v1,0/2] New state handling for VFIO CCW

Message ID 1557148270-19901-1-git-send-email-pmorel@linux.ibm.com (mailing list archive)
Headers show
Series New state handling for VFIO CCW | expand

Message

Pierre Morel May 6, 2019, 1:11 p.m. UTC
Hi,

I did not integrate all my patches for state handling like I had
before but just two patches which seems interresting to me:

- The first one allows the device ti be used only when a guest
  is currently using it.
  Otherwise the device is in NOT_OPER state
 
- The second rework the sch_event callback: AFAIU we can not
  consider that the event moves the device in IDLE state.
  I think we better let it as it is currently.

Regards,
Pierre

Pierre Morel (2):
  vfio-ccw: Set subchannel state STANDBY on open
  vfio-ccw: rework sch_event

 drivers/s390/cio/vfio_ccw_drv.c     | 21 ++-------------------
 drivers/s390/cio/vfio_ccw_fsm.c     |  7 +------
 drivers/s390/cio/vfio_ccw_ops.c     | 36 ++++++++++++++++++------------------
 drivers/s390/cio/vfio_ccw_private.h |  1 -
 4 files changed, 21 insertions(+), 44 deletions(-)

Comments

Cornelia Huck May 8, 2019, 9:53 a.m. UTC | #1
On Mon,  6 May 2019 15:11:08 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:

> Hi,
> 
> I did not integrate all my patches for state handling like I had
> before but just two patches which seems interresting to me:
> 
> - The first one allows the device ti be used only when a guest
>   is currently using it.
>   Otherwise the device is in NOT_OPER state
>  
> - The second rework the sch_event callback: AFAIU we can not
>   consider that the event moves the device in IDLE state.
>   I think we better let it as it is currently.

I agree with the direction of this patch series.

> 
> Regards,
> Pierre
> 
> Pierre Morel (2):
>   vfio-ccw: Set subchannel state STANDBY on open
>   vfio-ccw: rework sch_event
> 
>  drivers/s390/cio/vfio_ccw_drv.c     | 21 ++-------------------
>  drivers/s390/cio/vfio_ccw_fsm.c     |  7 +------
>  drivers/s390/cio/vfio_ccw_ops.c     | 36 ++++++++++++++++++------------------
>  drivers/s390/cio/vfio_ccw_private.h |  1 -
>  4 files changed, 21 insertions(+), 44 deletions(-)
>
Pierre Morel May 16, 2019, 8:59 a.m. UTC | #2
On 08/05/2019 11:53, Cornelia Huck wrote:
> On Mon,  6 May 2019 15:11:08 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
> 
>> Hi,
>>
>> I did not integrate all my patches for state handling like I had
>> before but just two patches which seems interresting to me:
>>
>> - The first one allows the device ti be used only when a guest
>>    is currently using it.
>>    Otherwise the device is in NOT_OPER state
>>   
>> - The second rework the sch_event callback: AFAIU we can not
>>    consider that the event moves the device in IDLE state.
>>    I think we better let it as it is currently.
> 
> I agree with the direction of this patch series.
> 
>>
>> Regards,
>> Pierre
>>
>> Pierre Morel (2):
>>    vfio-ccw: Set subchannel state STANDBY on open
>>    vfio-ccw: rework sch_event
>>
>>   drivers/s390/cio/vfio_ccw_drv.c     | 21 ++-------------------
>>   drivers/s390/cio/vfio_ccw_fsm.c     |  7 +------
>>   drivers/s390/cio/vfio_ccw_ops.c     | 36 ++++++++++++++++++------------------
>>   drivers/s390/cio/vfio_ccw_private.h |  1 -
>>   4 files changed, 21 insertions(+), 44 deletions(-)
>>
> 
Thanks,
I will post a v2 with the corrections seen by you and Farhan,

Regards,
Pierre