[kvm-unit-tests,v1,0/2] x86: Test IOAPIC physical and logical destination mode

Message

Nitesh Narayan Lal Nov. 6, 2019, 12:47 p.m. UTC

The first patch adds smp configuration to ioapic unittest and
the second one adds the support to test both physical and logical destination
modes under fixed delivery mode.

Nitesh Narayan Lal (2):
  x86: ioapic: Add the smp configuration to ioapic unittest
  x86: ioapic: Test physical and logical destination mode

 x86/ioapic.c      | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 x86/unittests.cfg |  1 +
 2 files changed, 66 insertions(+)

Comments

Nitesh Narayan Lal Nov. 22, 2019, 7:21 p.m. UTC | #1

On 11/6/19 7:47 AM, Nitesh Narayan Lal wrote:
> The first patch adds smp configuration to ioapic unittest and
> the second one adds the support to test both physical and logical destination
> modes under fixed delivery mode.
>
> Nitesh Narayan Lal (2):
>   x86: ioapic: Add the smp configuration to ioapic unittest
>   x86: ioapic: Test physical and logical destination mode
>
>  x86/ioapic.c      | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  x86/unittests.cfg |  1 +
>  2 files changed, 66 insertions(+)

I just wanted to check if there are any more suggestions or comments which I
need to address before this can be merged?

Marcelo Tosatti Nov. 22, 2019, 7:41 p.m. UTC | #2

On Wed, Nov 06, 2019 at 07:47:07AM -0500, Nitesh Narayan Lal wrote:
> The first patch adds smp configuration to ioapic unittest and
> the second one adds the support to test both physical and logical destination
> modes under fixed delivery mode.
> 
> Nitesh Narayan Lal (2):
>   x86: ioapic: Add the smp configuration to ioapic unittest
>   x86: ioapic: Test physical and logical destination mode
> 
>  x86/ioapic.c      | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  x86/unittests.cfg |  1 +
>  2 files changed, 66 insertions(+)

Looks good to me.

Paolo Bonzini Nov. 23, 2019, 10:33 a.m. UTC | #3

On 06/11/19 13:47, Nitesh Narayan Lal wrote:
> The first patch adds smp configuration to ioapic unittest and
> the second one adds the support to test both physical and logical destination
> modes under fixed delivery mode.
> 
> Nitesh Narayan Lal (2):
>   x86: ioapic: Add the smp configuration to ioapic unittest
>   x86: ioapic: Test physical and logical destination mode
> 
>  x86/ioapic.c      | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  x86/unittests.cfg |  1 +
>  2 files changed, 66 insertions(+)
> 

Applied, thanks.

Paolo