| Message ID | 20181114181507.6037-1-bp@alien8.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | x86/kvm: Enable MCE injection in the guest | expand |
On 14/11/18 19:15, Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > > Hi all, > > here's a rediff ontop of -rc2. No changes, only added Yazen's Tested-by. > > Please queue, > thx. > > Changelog: > ========== > > v2: > > here's v2, dropping patch 3 and incorporating hopefully all of Radim's > feedback. > > v1: > > there's this mce-inject.ko module in the kernel which allows for > injecting real MCEs and thus test the MCE handling code. > > It is doubly useful to be able to inject same MCEs in a guest so that > testing of the MCE handling code can happen even easier/faster. In order > to be able to do that on an AMD guest, we need to emulate some bits > and pieces like the HWCR[McStatusWrEn] bit which allows writes to the > MCi_STATUS registers without a #GP. > > The below does that and with it I'm able to properly inject MCEs in said > guest. > > -- > > Borislav Petkov (2): > kvm/x86: Move MSR_K7_HWCR to svm.c > x86/kvm: Implement MSR_HWCR support > > arch/x86/kvm/svm.c | 20 ++++++++++++++++++++ > arch/x86/kvm/x86.c | 46 +++++++++++++++++++++++++++++++--------------- > 2 files changed, 51 insertions(+), 15 deletions(-) > Queued, thanks. Paolo
On Mon, Nov 26, 2018 at 05:41:21PM +0100, Paolo Bonzini wrote: > On 14/11/18 19:15, Borislav Petkov wrote: > > From: Borislav Petkov <bp@suse.de> > > > > Hi all, > > > > here's a rediff ontop of -rc2. No changes, only added Yazen's Tested-by. > > > > Please queue, > > thx. > > > > Changelog: > > ========== > > > > v2: > > > > here's v2, dropping patch 3 and incorporating hopefully all of Radim's > > feedback. > > > > v1: > > > > there's this mce-inject.ko module in the kernel which allows for > > injecting real MCEs and thus test the MCE handling code. > > > > It is doubly useful to be able to inject same MCEs in a guest so that > > testing of the MCE handling code can happen even easier/faster. In order > > to be able to do that on an AMD guest, we need to emulate some bits > > and pieces like the HWCR[McStatusWrEn] bit which allows writes to the > > MCi_STATUS registers without a #GP. > > > > The below does that and with it I'm able to properly inject MCEs in said > > guest. > > > > -- > > > > Borislav Petkov (2): > > kvm/x86: Move MSR_K7_HWCR to svm.c > > x86/kvm: Implement MSR_HWCR support > > > > arch/x86/kvm/svm.c | 20 ++++++++++++++++++++ > > arch/x86/kvm/x86.c | 46 +++++++++++++++++++++++++++++++--------------- > > 2 files changed, 51 insertions(+), 15 deletions(-) > > > > Queued, thanks. Where? I don't see them in rc1...
From: Borislav Petkov <bp@suse.de> Hi all, here's a rediff ontop of -rc2. No changes, only added Yazen's Tested-by. Please queue, thx. Changelog: ========== v2: here's v2, dropping patch 3 and incorporating hopefully all of Radim's feedback. v1: there's this mce-inject.ko module in the kernel which allows for injecting real MCEs and thus test the MCE handling code. It is doubly useful to be able to inject same MCEs in a guest so that testing of the MCE handling code can happen even easier/faster. In order to be able to do that on an AMD guest, we need to emulate some bits and pieces like the HWCR[McStatusWrEn] bit which allows writes to the MCi_STATUS registers without a #GP. The below does that and with it I'm able to properly inject MCEs in said guest. -- Borislav Petkov (2): kvm/x86: Move MSR_K7_HWCR to svm.c x86/kvm: Implement MSR_HWCR support arch/x86/kvm/svm.c | 20 ++++++++++++++++++++ arch/x86/kvm/x86.c | 46 +++++++++++++++++++++++++++++++--------------- 2 files changed, 51 insertions(+), 15 deletions(-)