From patchwork Thu Apr 9 22:09:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wainer dos Santos Moschetta X-Patchwork-Id: 11482535 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4BE9792A for ; Thu, 9 Apr 2020 22:09:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D03C208E4 for ; Thu, 9 Apr 2020 22:09:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RWFHgXcA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbgDIWJV (ORCPT ); Thu, 9 Apr 2020 18:09:21 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:57702 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726797AbgDIWJU (ORCPT ); Thu, 9 Apr 2020 18:09:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586470160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=d0YWsJp6o5xV2UL2uS6Ygl+hmCi+0Eyl441GMe3mK+4=; b=RWFHgXcAGp5D+FvzAq++KyZR7mp8T7f/a3kqnWF7LrlucDHbL/imgjyMtjLdldjizFSjcs XBc3aLa3691AdCmlbrBOvJzHxMeq5wwicWCSoriUnEBynCsG8Ploi1hLcNXdeYa1PpNZER vNfiJEkxMhnYZJYoxlRuAfU0MLIgaqc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-GMJ2DFMMM52FoRdkcOgzgg-1; Thu, 09 Apr 2020 18:09:15 -0400 X-MC-Unique: GMJ2DFMMM52FoRdkcOgzgg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B06421007268; Thu, 9 Apr 2020 22:09:14 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-15.gru2.redhat.com [10.97.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 983379D348; Thu, 9 Apr 2020 22:09:08 +0000 (UTC) From: Wainer dos Santos Moschetta To: pbonzini@redhat.com, kvm@vger.kernel.org Cc: drjones@redhat.com, david@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, krish.sadhukhan@oracle.com Subject: [PATCH v5 0/2] selftests: kvm: Introduce the mem_slot_test test Date: Thu, 9 Apr 2020 19:09:03 -0300 Message-Id: <20200409220905.26573-1-wainersm@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org This series introduces a new KVM selftest (mem_slot_test) that goal is to verify memory slots can be added up to the maximum allowed. An extra slot is attempted which should occur on error. The patch 01 is needed so that the VM fd can be accessed from the test code (for the ioctl call attempting to add an extra slot). I ran the test successfully on x86_64, aarch64, and s390x. This is why it is enabled to build on those arches. - Changelog - v4 -> v5: - Initialize the guest_addr and mem_reg_size variables on definition [krish.sadhukhan] v3 -> v4: - Discarded mem_reg_flags variable. Simply using 0 instead [drjones] - Discarded kvm_region pointer. Instead passing a compound literal in the ioctl [drjones] - All variables are declared on the declaration block [drjones] v2 -> v3: - Keep alphabetical order of .gitignore and Makefile [drjones] - Use memory region flags equals to zero [drjones] - Changed mmap() assert from 'mem != NULL' to 'mem != MAP_FAILED' [drjones] - kvm_region is declared along side other variables and malloc()'ed later [drjones] - Combined two asserts into a single 'ret == -1 && errno == EINVAL' [drjones] v1 -> v2: - Rebased to queue - vm_get_fd() returns int instead of unsigned int (patch 01) [drjones] - Removed MEM_REG_FLAGS and GUEST_VM_MODE defines [drjones] - Replaced DEBUG() with pr_info() [drjones] - Calculate number of guest pages with vm_calc_num_guest_pages() [drjones] - Using memory region of 1 MB sized (matches mininum needed for s390x) - Removed the increment of guest_addr after the loop [drjones] - Added assert for the errno when adding a slot beyond-the-limit [drjones] - Prefer KVM_MEM_READONLY flag but on s390x it switch to KVM_MEM_LOG_DIRTY_PAGES, so ensure the coverage of both flags. Also somewhat tests the KVM_CAP_READONLY_MEM capability check [drjones] - Moved the test logic to test_add_max_slots(), this allows to more easily add new cases in the "suite". v1: https://lore.kernel.org/kvm/20200330204310.21736-1-wainersm@redhat.com Wainer dos Santos Moschetta (2): selftests: kvm: Add vm_get_fd() in kvm_util selftests: kvm: Add mem_slot_test test tools/testing/selftests/kvm/.gitignore | 1 + tools/testing/selftests/kvm/Makefile | 3 + .../testing/selftests/kvm/include/kvm_util.h | 1 + tools/testing/selftests/kvm/lib/kvm_util.c | 5 ++ tools/testing/selftests/kvm/mem_slot_test.c | 69 +++++++++++++++++++ 5 files changed, 79 insertions(+) create mode 100644 tools/testing/selftests/kvm/mem_slot_test.c