From patchwork Thu Apr 1 14:18:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Levitsky X-Patchwork-Id: 12179193 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44724C43461 for ; Thu, 1 Apr 2021 18:23:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CAA4601FC for ; Thu, 1 Apr 2021 18:23:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234915AbhDASXl (ORCPT ); Thu, 1 Apr 2021 14:23:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37281 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235296AbhDASVD (ORCPT ); Thu, 1 Apr 2021 14:21:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617301262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Gy/ng5zCwEi0kvaEHLz2eineziKHWcaMJpVr9bUxhnU=; b=eVbfKshU0rpWhdVZISL+3gKcPPe2dx13MEssTleOKUce4PvALxlsUje8ppFQOOpgjg6QPq uWgTHCR2w9j/BP28yGgsrQjqRHFePTQ0gcE+BsWyrDXNd2dnY+JiWb4PkxVGfUfrMQ13x+ lFe5teYzKZrUOMTpY9KPqIW9txVZX4Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-o6gNyiRcMtqFtV05SKEVdg-1; Thu, 01 Apr 2021 10:19:01 -0400 X-MC-Unique: o6gNyiRcMtqFtV05SKEVdg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17C831853032; Thu, 1 Apr 2021 14:18:20 +0000 (UTC) Received: from localhost.localdomain (unknown [10.35.206.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC2AA6F7EA; Thu, 1 Apr 2021 14:18:15 +0000 (UTC) From: Maxim Levitsky To: kvm@vger.kernel.org Cc: x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), Jim Mattson , Vitaly Kuznetsov , Wanpeng Li , Sean Christopherson , Joerg Roedel , "H. Peter Anvin" , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), Paolo Bonzini , Thomas Gleixner , Jonathan Corbet , Borislav Petkov , Ingo Molnar , linux-doc@vger.kernel.org (open list:DOCUMENTATION), Maxim Levitsky Subject: [PATCH 0/6] Introduce KVM_{GET|SET}_SREGS2 and fix PDPTR migration Date: Thu, 1 Apr 2021 17:18:08 +0300 Message-Id: <20210401141814.1029036-1-mlevitsk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org This patch set aims to fix few flaws that were discovered in KVM_{GET|SET}_SREGS on x86: * There is no support for reading/writing PDPTRs although these are considered to be part of the guest state. * There is useless interrupt bitmap which isn't needed * No support for future extensions (via flags and such) Final two patches in this patch series allow to correctly migrate PDPTRs when new API is used. This patch series was tested by doing nested migration test of 32 bit PAE L1 + 32 bit PAE L2 on AMD and Intel and by nested migration test of 64 bit L1 + 32 bit PAE L2 on AMD. The later test currently fails on Intel (regardless of my patches). Finally patch 2 in this patch series fixes a rare L0 kernel oops, which I can trigger by migrating a hyper-v machine. Best regards, Maxim Levitskky Maxim Levitsky (6): KVM: nVMX: delay loading of PDPTRs to KVM_REQ_GET_NESTED_STATE_PAGES KVM: nSVM: call nested_svm_load_cr3 on nested state load KVM: x86: introduce kvm_register_clear_available KVM: x86: Introduce KVM_GET_SREGS2 / KVM_SET_SREGS2 KVM: nSVM: avoid loading PDPTRs after migration when possible KVM: nVMX: avoid loading PDPTRs after migration when possible Documentation/virt/kvm/api.rst | 43 ++++++++++ arch/x86/include/asm/kvm_host.h | 7 ++ arch/x86/include/uapi/asm/kvm.h | 13 +++ arch/x86/kvm/kvm_cache_regs.h | 12 +++ arch/x86/kvm/svm/nested.c | 55 ++++++++----- arch/x86/kvm/svm/svm.c | 6 +- arch/x86/kvm/vmx/nested.c | 26 ++++-- arch/x86/kvm/x86.c | 136 ++++++++++++++++++++++++++------ include/uapi/linux/kvm.h | 5 ++ 9 files changed, 249 insertions(+), 54 deletions(-)