mbox series

[0/5] KVM: x86/mmu: Clean up {Host,MMU}-writable documentation and validation

Message ID 20220125230518.1697048-1-dmatlack@google.com (mailing list archive)
Headers show
Series KVM: x86/mmu: Clean up {Host,MMU}-writable documentation and validation | expand

Message

David Matlack Jan. 25, 2022, 11:05 p.m. UTC
This series cleans up some documentation and WARNings related to
MMU-writable and Host-writable bits based on suggestions from Sean on
another patch [1].

[1] https://lore.kernel.org/kvm/YeH5QlwgGcpStZyp@google.com/

David Matlack (5):
  KVM: x86/mmu: Move SPTE writable invariant checks to a helper function
  KVM: x86/mmu: Check SPTE writable invariants when setting leaf SPTEs
  KVM: x86/mmu: Move is_writable_pte() to spte.h
  KVM: x86/mmu: Rename DEFAULT_SPTE_MMU_WRITEABLE to
    DEFAULT_SPTE_MMU_WRITABLE
  KVM: x86/mmu: Consolidate comments about {Host,MMU}-writable

 arch/x86/kvm/mmu.h         |  38 -------------
 arch/x86/kvm/mmu/mmu.c     |  11 ++--
 arch/x86/kvm/mmu/spte.c    |  13 +----
 arch/x86/kvm/mmu/spte.h    | 113 +++++++++++++++++++++++++++----------
 arch/x86/kvm/mmu/tdp_mmu.c |   3 +
 5 files changed, 93 insertions(+), 85 deletions(-)


base-commit: e2e83a73d7ce66f62c7830a85619542ef59c90e4

Comments

David Matlack Jan. 25, 2022, 11:16 p.m. UTC | #1
On Tue, Jan 25, 2022 at 3:05 PM David Matlack <dmatlack@google.com> wrote:
>
> This series cleans up some documentation and WARNings related to
> MMU-writable and Host-writable bits based on suggestions from Sean on
> another patch [1].
>
> [1] https://lore.kernel.org/kvm/YeH5QlwgGcpStZyp@google.com/
>
> David Matlack (5):
>   KVM: x86/mmu: Move SPTE writable invariant checks to a helper function
>   KVM: x86/mmu: Check SPTE writable invariants when setting leaf SPTEs
>   KVM: x86/mmu: Move is_writable_pte() to spte.h
>   KVM: x86/mmu: Rename DEFAULT_SPTE_MMU_WRITEABLE to
>     DEFAULT_SPTE_MMU_WRITABLE
>   KVM: x86/mmu: Consolidate comments about {Host,MMU}-writable

The email threading on this series got a bit messed up (at least on
lore). I had a misspelling in the signed-off-by tag in patch 4 that
was caught by git-send-email after sending the cover letter and
patches 1-3. So I fixed it and sent patch 4 and 5 separately.

I can resend the series again if anyone prefers.

>
>  arch/x86/kvm/mmu.h         |  38 -------------
>  arch/x86/kvm/mmu/mmu.c     |  11 ++--
>  arch/x86/kvm/mmu/spte.c    |  13 +----
>  arch/x86/kvm/mmu/spte.h    | 113 +++++++++++++++++++++++++++----------
>  arch/x86/kvm/mmu/tdp_mmu.c |   3 +
>  5 files changed, 93 insertions(+), 85 deletions(-)
>
>
> base-commit: e2e83a73d7ce66f62c7830a85619542ef59c90e4
> --
> 2.35.0.rc0.227.g00780c9af4-goog
>
Paolo Bonzini Feb. 1, 2022, 12:22 p.m. UTC | #2
On 1/26/22 00:16, David Matlack wrote:
>>
>> David Matlack (5):
>>    KVM: x86/mmu: Move SPTE writable invariant checks to a helper function
>>    KVM: x86/mmu: Check SPTE writable invariants when setting leaf SPTEs
>>    KVM: x86/mmu: Move is_writable_pte() to spte.h
>>    KVM: x86/mmu: Rename DEFAULT_SPTE_MMU_WRITEABLE to
>>      DEFAULT_SPTE_MMU_WRITABLE
>>    KVM: x86/mmu: Consolidate comments about {Host,MMU}-writable
> The email threading on this series got a bit messed up (at least on
> lore). I had a misspelling in the signed-off-by tag in patch 4 that
> was caught by git-send-email after sending the cover letter and
> patches 1-3. So I fixed it and sent patch 4 and 5 separately.
> 
> I can resend the series again if anyone prefers.
> 

Not sure how that's even possible, but Thunderbird showed me correct 
threading.  Patch queued now, thanks.

Next time this happens you can send the other patches with --in-reply-to 
--no-thread:

        --in-reply-to=<identifier>
            Make the first mail (or all the mails with --no-thread)
            appear as a reply to the given Message-Id [...]

Thanks,

Paolo