From patchwork Thu Jun 16 23:52:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolin Chen X-Patchwork-Id: 12884998 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BDDCCCA47C for ; Thu, 16 Jun 2022 23:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379456AbiFPXxS (ORCPT ); Thu, 16 Jun 2022 19:53:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378261AbiFPXxR (ORCPT ); Thu, 16 Jun 2022 19:53:17 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2071.outbound.protection.outlook.com [40.107.93.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D139560071; Thu, 16 Jun 2022 16:53:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JKZehjgatXEfbsV4oveKMYMLLP1hFmyL5ap7OZeAlNRfcIF3VNNW+HmywfSGjLK2Suoq12BP9usszt9OCRkVFNzOLtcjvNnxFuETcbRadxYak7EOA5wj187WILJxtxCrjho9eQihM9xes285XpBrKEkvl/if4c/DblnNYYh4pHFQL35JEHkE50K42rTcr+Iq8Ry5sZ5ihR+oiWlVvdr5DZ5RwunMkaSIzLiS1UQNu0tfZdLL1uQq0wRd3WDOS9BdpLMbcOY58viXAkSN7i0HT+cYMFoNTioJ69eYtVo+xBDcSl/2TU0PcaBRjODZHUPMWKpw2NznDBYglPvht7IPQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BTVEbGIqANGV1nCYY5JLveZ8+X+S9FhO3K30tJcpdHQ=; b=UmigOT8rNPgu2xnbfPoXEGXfhSOMdDroiezMLVj9BL2qV0mjnZS0ll5V3YUZFyxr0II4DNxtPDFh7fKxeCJWicfDyCdh2MXEAt/JvbbkIPfNK+rAnVPpUqCozEj6WeMdRXPMWnbEJpvcXns55u6rZXepjO3Pbfm9ggN9brC395G2ibm/iM73zFcr2+8y8r9OTP67oI56veOHTCenqNANAlSm//jrUvA3TF8nTz4flOFBiO/vPkr+eTQc7eCVVPTnEF1oPk42MFG/SujnH4jTQq52hViyoTLuoDB8+UNgj0bjjq5zPe1RczAHoEtjUCDw6ohXxR+OIJAytrKy1y7WLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BTVEbGIqANGV1nCYY5JLveZ8+X+S9FhO3K30tJcpdHQ=; b=Ap61RI/cOCJVd6hflxMkp3ejqo9nUIbSf7I5l5ylX3+lwX9By+/NqioLQNkqcxGW/4VEsH6DQfSVqDIplMzFc+EdCZmZXhjZQvM3fR/c2vwYeQhyGrD59JMPaCNZVUSntxMLm91F4C4QS6/RFi/amMacYK9eZbbQSLhejTy+I76oS035q4Mrxayn3U4nU05pjvPFHFJ06iB0SxYGREXbBFZu+kGmlFsV8a80iyMaxQjdfUAvLwmZg6VPskTI1gDB1PNMTdGvjCYeT6mEyzv99VwmtJbb8DFCW6wMfsAMmbD0ncPS9ZhfZXveTUlrI7uxHI270jnhB26rHJwz2LznKg== Received: from DM6PR03CA0045.namprd03.prod.outlook.com (2603:10b6:5:100::22) by DS0PR12MB6440.namprd12.prod.outlook.com (2603:10b6:8:c8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.20; Thu, 16 Jun 2022 23:53:14 +0000 Received: from DM6NAM11FT035.eop-nam11.prod.protection.outlook.com (2603:10b6:5:100:cafe::9a) by DM6PR03CA0045.outlook.office365.com (2603:10b6:5:100::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.15 via Frontend Transport; Thu, 16 Jun 2022 23:53:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.236) by DM6NAM11FT035.mail.protection.outlook.com (10.13.172.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Thu, 16 Jun 2022 23:53:14 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 16 Jun 2022 23:53:13 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 16 Jun 2022 16:53:12 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.986.22 via Frontend Transport; Thu, 16 Jun 2022 16:53:10 -0700 From: Nicolin Chen To: , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , Subject: [RFT][PATCH v1 0/6] Update vfio_pin/unpin_pages API Date: Thu, 16 Jun 2022 16:52:06 -0700 Message-ID: <20220616235212.15185-1-nicolinc@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 602ead53-8a49-4af1-65bc-08da4ff360ba X-MS-TrafficTypeDiagnostic: DS0PR12MB6440:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qcwaPb2PpVz7cdMw6qJdjIUdGKk6STX9REICK5rRKbR05MMqCwwJoqc9cUlgL0mMRxCZYtq6tSRuvjZUl+hU+J48gOeaMA3D2OblX/rUx+w4GLitLORBDcd3aa5KaZvzDqwcNFLf/cjH/6UmiLDhddKzTjcEQviGKEQSEg8J64u3VNSa4x89p0/qbQEnkENWChw0kIh8lNApLJtYaBs/yt+fK1A2PXidHvV2A6aurx2e8kvUmf70FJEAaQuLnwgg0p+Xxxtx9Fyn9SjdYR96M9iY0CdAIZVCZv3m/xZGbgAFvunnX6uZoqKv+EGWoMJtalDG0q1KTg0m58DZQ748Z0rPCp2hAqJUHxUE2Oz7FuVA0otx2spJkDFTRyTzfvI2HCPMuN2UY3WoJl0K5Bt2Sf12dXYDXg2Qge4aBq9ORIJuWduLMgHSFF+fdRQ9MO12PkW8cLZyWEgGiD+ch84oPp4pphZOMVFm/jLJLYRiTn44X+MvmJp7Y0MtCGxtmV1/gTU6S+kN+Zu1DZFDDs6jeFt2hgGghtp1Yh+pAMfE55I2xkQHf8lA+fO2/7QxgZLkC8ZXUox2E4zijp1iEZrdsDvhF48XpXHtFLnf1tnKxm7heDQ+Ofe/XKgX7wnn+b5vNE575IyD9Zs1OrqY84KAPgLjIbb1I9lIGEKLlIdOwmjCA7BvMYTWBK8KRbntMeykIhmcofbeooEmWIEYdFdHt5LPA8tUHbc+sSlGTayI56C+1KM8m6y6c4+TPUIboX36u2O0uEk6n52uUH8Hbn1vvxlzISPIcfhw/8WCzXhLpEOQ/+NRWR1cmADpM9rEdUb9rXbNYJwVaYG8ZbDKxyryYo2QGJOUDHaDwP3mnWdQHYM= X-Forefront-Antispam-Report: CIP:12.22.5.236;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:InfoNoRecords;CAT:NONE;SFS:(13230016)(4636009)(46966006)(40470700004)(36840700001)(186003)(2616005)(26005)(81166007)(83380400001)(426003)(356005)(336012)(316002)(1076003)(82310400005)(47076005)(36860700001)(498600001)(2906002)(8936002)(7416002)(7696005)(7406005)(36756003)(110136005)(4326008)(8676002)(40460700003)(5660300002)(6666004)(15650500001)(54906003)(70206006)(86362001)(921005)(70586007)(966005)(36900700001)(83996005)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2022 23:53:14.3572 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 602ead53-8a49-4af1-65bc-08da4ff360ba X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.236];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT035.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6440 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org This is a preparatory series for IOMMUFD v2 patches. It prepares for replacing vfio_iommu_type1 implementations of vfio_pin/unpin_pages() with IOMMUFD version. There's a gap between these two versions: the vfio_iommu_type1 version inputs a non-contiguous PFN list and outputs another PFN list for the pinned physical page list, while the IOMMUFD version only supports a contiguous address input by accepting the starting IO virtual address of a set of pages to pin and by outputting to a physical page list. The nature of existing callers mostly aligns with the IOMMUFD version, except s390's vfio_ccw_cp code where some additional change is needed along with this series. Overall, updating to "iova" and "phys_page" does improve the caller side to some extent. Also fix a misuse of physical address and virtual address in the s390's crypto code. And update the input naming at the adjacent vfio_dma_rw(). This is on github: https://github.com/nicolinc/iommufd/commits/vfio_pin_pages Request for testing: I only did build for s390 and i915 code, so it'd be nice to have people who have environment to run sanity accordingly. Thanks! Nicolin Chen (6): vfio/ap: Pass in physical address of ind to ap_aqic() vfio/ccw: Only pass in contiguous pages vfio: Pass in starting IOVA to vfio_pin/unpin_pages API vfio: Rename user_iova of vfio_dma_rw() vfio/ccw: Add kmap_local_page() for memcpy vfio: Replace phys_pfn with phys_page for vfio_pin_pages() .../driver-api/vfio-mediated-device.rst | 6 +- arch/s390/include/asm/ap.h | 6 +- drivers/gpu/drm/i915/gvt/kvmgt.c | 44 ++++----- drivers/s390/cio/vfio_ccw_cp.c | 90 ++++++++++++++----- drivers/s390/crypto/ap_queue.c | 2 +- drivers/s390/crypto/vfio_ap_ops.c | 21 ++--- drivers/vfio/vfio.c | 38 ++++---- drivers/vfio/vfio.h | 6 +- drivers/vfio/vfio_iommu_type1.c | 34 +++---- include/linux/vfio.h | 8 +- 10 files changed, 142 insertions(+), 113 deletions(-)