From patchwork Wed Aug 10 17:15:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eugenio Perez Martin X-Patchwork-Id: 12940826 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9119BC00140 for ; Wed, 10 Aug 2022 17:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233394AbiHJRP2 (ORCPT ); Wed, 10 Aug 2022 13:15:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233382AbiHJRP0 (ORCPT ); Wed, 10 Aug 2022 13:15:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3EE395A2C0 for ; Wed, 10 Aug 2022 10:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660151724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pJn/IZwwCUJaRkHAplLUe6h5lh+4WbyzcUt1/ayUEH8=; b=OqQN4JqvrM099LQ5X4HjLcpnbKpTzZELkEldiRXjqsqtZiprskUjiTn4IYs+tB+vzjy8fj zX8eFM6DSjcfLAifavF+E7u0I/0twcxekRdyiyKcXIBTx3fNw902Uawbq5Hyk8zxq1oqt2 UrtgNqwgMvuyC33R96YwWwW6HnCmfHs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-509-8vtarA0BMqWU1cnKiPawGg-1; Wed, 10 Aug 2022 13:15:20 -0400 X-MC-Unique: 8vtarA0BMqWU1cnKiPawGg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83E5F1C006C3; Wed, 10 Aug 2022 17:15:19 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id 344011410DDA; Wed, 10 Aug 2022 17:15:14 +0000 (UTC) From: =?utf-8?q?Eugenio_P=C3=A9rez?= To: kvm@vger.kernel.org, "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, Jason Wang , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Cc: dinang@xilinx.com, martinpo@xilinx.com, Wu Zongyong , Piotr.Uminski@intel.com, gautam.dawar@amd.com, ecree.xilinx@gmail.com, martinh@xilinx.com, Stefano Garzarella , pabloc@xilinx.com, habetsm.xilinx@gmail.com, lvivier@redhat.com, Zhu Lingshan , tanuj.kamde@amd.com, Longpeng , lulu@redhat.com, hanand@xilinx.com, Parav Pandit , Si-Wei Liu , Eli Cohen , Xie Yongji , Zhang Min , Dan Carpenter , Christophe JAILLET Subject: [PATCH v7 0/4] Implement vdpasim suspend operation Date: Wed, 10 Aug 2022 19:15:08 +0200 Message-Id: <20220810171512.2343333-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Implement suspend operation for vdpa_sim devices, so vhost-vdpa will offer that backend feature and userspace can effectively suspend the device. This is a must before getting virtqueue indexes (base) for live migration, since the device could modify them after userland gets them. There are individual ways to perform that action for some devices (VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there was no way to perform it for any vhost device (and, in particular, vhost-vdpa). After a successful return of ioctl the device must not process more virtqueue descriptors. The device can answer to read or writes of config fields as if it were not suspended. In particular, writing to "queue_enable" with a value of 1 will not make the device start processing virtqueue buffers. In the future, we will provide features similar to VHOST_USER_GET_INFLIGHT_FD so the device can save pending operations. Applied on top of [1] branch after removing the old commits. Comments are welcome. v7: * Remove ioctl leftover argument and update doc accordingly. v6: * Remove the resume operation, making the ioctl simpler. We can always add another ioctl for VM_STOP/VM_RESUME operation later. * s/stop/suspend/ to differentiate more from reset. * Clarify scope of the suspend operation. v5: * s/not stop/resume/ in doc. v4: * Replace VHOST_STOP to VHOST_VDPA_STOP in vhost ioctl switch case too. v3: * s/VHOST_STOP/VHOST_VDPA_STOP/ * Add documentation and requirements of the ioctl above its definition. v2: * Replace raw _F_STOP with BIT_ULL(_F_STOP). * Fix obtaining of stop ioctl arg (it was not obtained but written). * Add stop to vdpa_sim_blk. [1] git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git Eugenio Pérez (4): vdpa: Add suspend operation vhost-vdpa: introduce SUSPEND backend feature bit vhost-vdpa: uAPI to suspend the device vdpa_sim: Implement suspend vdpa op drivers/vdpa/vdpa_sim/vdpa_sim.c | 14 +++++++++++ drivers/vdpa/vdpa_sim/vdpa_sim.h | 1 + drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 3 +++ drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 3 +++ drivers/vhost/vdpa.c | 35 +++++++++++++++++++++++++++- include/linux/vdpa.h | 4 ++++ include/uapi/linux/vhost.h | 9 +++++++ include/uapi/linux/vhost_types.h | 2 ++ 8 files changed, 70 insertions(+), 1 deletion(-)