mbox series

[kvm-unit-tests,0/2] x86: Fixes for rdpid test

Message ID 20230307005547.607353-1-dmatlack@google.com (mailing list archive)
Headers show
Series x86: Fixes for rdpid test | expand

Message

David Matlack March 7, 2023, 12:55 a.m. UTC
Fix 2 small issues with the rdpid test that is a part of x86/tsc.c.
Notably, the test is not currently running since qemu is not configured
to advertise RDPID support and fixing that uncovers a bug in the test
when compiling with Clang.

David Matlack (2):
  x86: Run the tsc test with -cpu max
  x86: Mark RDPID asm volatile to avoid dropping instructions

 x86/tsc.c         | 2 +-
 x86/unittests.cfg | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


base-commit: e3c5c3ef2524c58023073c0fadde2e8ae3c04ec6

Comments

Paolo Bonzini March 13, 2023, 2:55 p.m. UTC | #1
On 3/7/23 01:55, David Matlack wrote:
> Fix 2 small issues with the rdpid test that is a part of x86/tsc.c.
> Notably, the test is not currently running since qemu is not configured
> to advertise RDPID support and fixing that uncovers a bug in the test
> when compiling with Clang.
> 
> David Matlack (2):
>    x86: Run the tsc test with -cpu max
>    x86: Mark RDPID asm volatile to avoid dropping instructions
> 
>   x86/tsc.c         | 2 +-
>   x86/unittests.cfg | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> base-commit: e3c5c3ef2524c58023073c0fadde2e8ae3c04ec6

Queued, thanks.

Paolo
Sean Christopherson April 5, 2023, 11 p.m. UTC | #2
On Mon, 06 Mar 2023 16:55:45 -0800, David Matlack wrote:
> Fix 2 small issues with the rdpid test that is a part of x86/tsc.c.
> Notably, the test is not currently running since qemu is not configured
> to advertise RDPID support and fixing that uncovers a bug in the test
> when compiling with Clang.
> 
> David Matlack (2):
>   x86: Run the tsc test with -cpu max
>   x86: Mark RDPID asm volatile to avoid dropping instructions
> 
> [...]

Applied to kvm-x86 next, thanks!  Paolo's "Queued, thanks" showed up, but I
don't see these in upstream.

[1/2] x86: Run the tsc test with -cpu max
      https://github.com/kvm-x86/kvm-unit-tests/commit/572fb7097fa7
[2/2] x86: Mark RDPID asm volatile to avoid dropping instructions
      https://github.com/kvm-x86/kvm-unit-tests/commit/a467f7679c7f

--
https://github.com/kvm-x86/kvm-unit-tests/tree/next