[kvm-unit-tests,v3,0/9] s390x: uv-host: Fixups and extensions part 1

Message

Janosch Frank May 2, 2023, 1:07 p.m. UTC

The uv-host test has a lot of historical growth problems which have
largely been overlooked since running it is harder than running a KVM
(guest 2) based test.

This series fixes up smaller problems but still leaves the test with
fails when running create config base and variable storage
tests. Those problems will either be fixed up with the second series
or with a firmware fix since I'm unsure on which side of the os/fw
fence the problem exists.

The series is based on my other series that introduces pv-ipl and
pv-icpt. The memory allocation fix will be added to the new version of
that series so all G1 tests are fixed.

v3:
	- Re-based on the ipl/icpt series
	- Added review-bys

v2:
	- Added patch that exchanges sigp_retry with the smp variant
	- Re-worked the create config test handling
	- Minor fixups

Janosch Frank (9):
  s390x: uv-host: Fix UV init test memory allocation
  s390x: uv-host: Check for sufficient amount of memory
  s390x: uv-host: Beautify code
  s390x: uv-host: Add cpu number check
  s390x: uv-host: Fix create guest variable storage prefix check
  s390x: uv-host: Switch to smp_sigp
  s390x: uv-host: Properly handle config creation errors
  s390x: uv-host: Fence access checks when UV debug is enabled
  s390x: uv-host: Add the test to unittests.conf

 lib/s390x/asm/uv.h  |   1 +
 s390x/unittests.cfg |   5 ++
 s390x/uv-host.c     | 137 ++++++++++++++++++++++++++++++++++----------
 3 files changed, 114 insertions(+), 29 deletions(-)

Comments

Nico Boehr May 31, 2023, 2:47 p.m. UTC | #1

Quoting Janosch Frank (2023-05-02 15:07:23)
> The uv-host test has a lot of historical growth problems which have
> largely been overlooked since running it is harder than running a KVM
> (guest 2) based test.
> 
> This series fixes up smaller problems but still leaves the test with
> fails when running create config base and variable storage
> tests. Those problems will either be fixed up with the second series
> or with a firmware fix since I'm unsure on which side of the os/fw
> fence the problem exists.
> 
> The series is based on my other series that introduces pv-ipl and
> pv-icpt. The memory allocation fix will be added to the new version of
> that series so all G1 tests are fixed.

I have also pushed this to our CI, thanks.

Also here, I took the liberty of adding
groups = pv-host
in the last patch. If you are OK with it, I can carry that when picking for the
PR.

Janosch Frank June 2, 2023, 8:10 a.m. UTC | #2

On 5/31/23 16:47, Nico Boehr wrote:
> Quoting Janosch Frank (2023-05-02 15:07:23)
>> The uv-host test has a lot of historical growth problems which have
>> largely been overlooked since running it is harder than running a KVM
>> (guest 2) based test.
>>
>> This series fixes up smaller problems but still leaves the test with
>> fails when running create config base and variable storage
>> tests. Those problems will either be fixed up with the second series
>> or with a firmware fix since I'm unsure on which side of the os/fw
>> fence the problem exists.
>>
>> The series is based on my other series that introduces pv-ipl and
>> pv-icpt. The memory allocation fix will be added to the new version of
>> that series so all G1 tests are fixed.
> 
> I have also pushed this to our CI, thanks.
> 
> Also here, I took the liberty of adding
> groups = pv-host
> in the last patch. If you are OK with it, I can carry that when picking for the
> PR.

Sure, since Thomas reviewed the patch introducing the group I'm fine 
with that.