mbox series

[kvm-unit-tests,0/3] migration: fixes and multiple migration

Message ID 20230725033937.277156-1-npiggin@gmail.com (mailing list archive)
Headers show
Series migration: fixes and multiple migration | expand

Message

Nicholas Piggin July 25, 2023, 3:39 a.m. UTC
Spent too long looking at bash code after posting previous RFC, but
got it into shape.

The first 2 seem to be real bugs you can trigger by making a test
case fail. Third IMO is pretty solid now but no users yet so I can
keep it around and resubmit with a user some time later.

Thanks,
Nick

Nicholas Piggin (3):
  migration: Fix test harness hang on fifo
  migration: Fix test harness hang if source does not reach migration
    point
  arch-run: Support multiple migrations

 lib/migrate.c         |  8 +++---
 lib/migrate.h         |  1 +
 scripts/arch-run.bash | 65 ++++++++++++++++++++++++++++++++++++-------
 3 files changed, 60 insertions(+), 14 deletions(-)

Comments

Shaoqin Huang July 28, 2023, 8:44 a.m. UTC | #1
Hi Nicholas,

With the patch3 arch-run: Support multiple migrations.

The run_test.sh will fail on the migration test on arm64 platform. But 
the patch1 and patch2 looks good, only apply these two patches the 
migration test works good.

I haven't had time to investigate it. But first let you know that.

Thanks,
Shaoqin

On 7/25/23 11:39, Nicholas Piggin wrote:
> Spent too long looking at bash code after posting previous RFC, but
> got it into shape.
> 
> The first 2 seem to be real bugs you can trigger by making a test
> case fail. Third IMO is pretty solid now but no users yet so I can
> keep it around and resubmit with a user some time later.
> 
> Thanks,
> Nick
> 
> Nicholas Piggin (3):
>    migration: Fix test harness hang on fifo
>    migration: Fix test harness hang if source does not reach migration
>      point
>    arch-run: Support multiple migrations
> 
>   lib/migrate.c         |  8 +++---
>   lib/migrate.h         |  1 +
>   scripts/arch-run.bash | 65 ++++++++++++++++++++++++++++++++++++-------
>   3 files changed, 60 insertions(+), 14 deletions(-)
>
Nicholas Piggin July 30, 2023, 10:06 a.m. UTC | #2
On Fri Jul 28, 2023 at 6:44 PM AEST, Shaoqin Huang wrote:
> Hi Nicholas,
>
> With the patch3 arch-run: Support multiple migrations.
>
> The run_test.sh will fail on the migration test on arm64 platform. But 
> the patch1 and patch2 looks good, only apply these two patches the 
> migration test works good.
>
> I haven't had time to investigate it. But first let you know that.

Hey, thanks for testing. I noticed some problem with it too. Let's
leave patch 3 out for now, I'll post an update with some users
added and hopefully bugs fixed.

Thanks,
Nick