[kvm-unit-tests,v2,0/3] s390x: Improve console handling

Message

Janosch Frank Oct. 31, 2023, 9:55 a.m. UTC

Console IO is and has been in a state of "works for me". I don't think
that will change soon since there's no need for a proper console
driver when all we want is the ability to print or read a line at a
time.

However since input is only supported on the ASCII console I was
forced to use it on the HMC. The HMC generally does not add a \r on a
\n so each line doesn't start at column 0. It's time to finally fix
that.

Also, since there are environments that only provide the line-mode
console it's time to add line-mode input to properly support them.

v2:
	* Reworked detect_host routine to support being called in early setup
	* Added length checks in sclp_print_ascii for compat handling
	* Added Linux reference to lib/s390x/sclp-console.c header
v1:
	* Fenced ASCII compat handling so it's only use in LPAR
	* Squashed compat handling into one patch
	* Added an early detect_host since SCLP might be used in setup
	* Fixed up a few formatting issues in input patch
	* Fixed up copyright stuff

Janosch Frank (3):
  lib: s390x: hw: rework do_detect_host so we don't need allocation
  lib: s390x: sclp: Add compat handling for HMC ASCII consoles
  lib: s390x: sclp: Add line mode input handling

 lib/s390x/hardware.c     |  11 +--
 lib/s390x/sclp-console.c | 206 +++++++++++++++++++++++++++++++++++----
 lib/s390x/sclp.h         |  26 ++++-
 3 files changed, 215 insertions(+), 28 deletions(-)

Comments

Nico Boehr Nov. 3, 2023, 9:37 a.m. UTC | #1

Quoting Janosch Frank (2023-10-31 10:55:16)
> Console IO is and has been in a state of "works for me". I don't think
> that will change soon since there's no need for a proper console
> driver when all we want is the ability to print or read a line at a
> time.
> 
> However since input is only supported on the ASCII console I was
> forced to use it on the HMC. The HMC generally does not add a \r on a
> \n so each line doesn't start at column 0. It's time to finally fix
> that.
> 
> Also, since there are environments that only provide the line-mode
> console it's time to add line-mode input to properly support them.

Pushed to our internal CI for coverage, thanks.

Nico Boehr Nov. 7, 2023, 9:05 a.m. UTC | #2

Quoting Janosch Frank (2023-10-31 10:55:16)
> Console IO is and has been in a state of "works for me". I don't think
> that will change soon since there's no need for a proper console
> driver when all we want is the ability to print or read a line at a
> time.
> 
> However since input is only supported on the ASCII console I was
> forced to use it on the HMC. The HMC generally does not add a \r on a
> \n so each line doesn't start at column 0. It's time to finally fix
> that.
> 
> Also, since there are environments that only provide the line-mode
> console it's time to add line-mode input to properly support them.

Thanks, queued.