[v6,0/2] vfio/pci: add interrupt affinity support

Message

Fred Griffoul June 11, 2024, 5:44 p.m. UTC

v6:
 - corrections following review from Alex Williamson
   <[e-mail]>:
   - rename the new flag VFIO_IRQ_SET_DATA_CPUSET.
   - add a new VFIO_IRQ_INFO_CPUSET flag for IRQ_INFO.
   - rename the new vfio pci function vfio_pci_set_affinity()
     and calls it for both msi or intx interrupt.
   - use size_mul() for the VFIO_IRQ_SET_DATA_BOOL data
     size computation.
   - remove the specific cpumask_var_t allocation/release to
     handle DATA_CPUSET data copy as all the other flags, with
     the generic memdup_user(). The minor drawback is we then
     have to reject a cpu_set_t data smaller than the actual
     cpumask kernel structure.
  - in vfio_pci_set_affinity() use pci_irq_vector() to retrieve
    the irq number of each vector.

v5:
 - vfio_pci_ioctl_set_irqs(): fix copy_from_user() check when copying
   the cpumask argument. Reported by Dan Carpenter
   <[e-mail]>
 - vfio_set_irqs_validate_and_prepare(): use size_mul() to compute the
   data size of a VFIO_IRQ_SET_DATA_EVENTFD ioctl() to avoid a possible
   overflow on 32-bit system. Reported by Dan Carpenter
   <[e-mail]>
 - export system_32bit_el0_cpumask() to fix yet another missing symbol
   for arm64 architecture.

v4:
 - export arm64_mismatched_32bit_el0 to compile the vfio driver as
   a kernel module on arm64 if CONFIG_CPUSETS is not defined.
 - vfio_pci_ioctl_set_irqs(): free the cpumask_var_t only if data_size
   is not zero, otherwise it was not allocated.
 - vfio_pci_set_msi_trigger(): call the new function
   vfio_pci_set_msi_affinity() later, after the DATA_EVENTFD
   processing and the vdev index check.

v3:
 - add a first patch to export cpuset_cpus_allowed() to be able to
   compile the vfio driver as a kernel module.

v2:
 - change the ioctl() interface to use a cpu_set_t in vfio_irq_set
   'data' to keep the 'start' and 'count' semantic, as suggested by
    David Woodhouse <[e-mail]>

v1:

The usual way to configure a device interrupt from userland is to write
the /proc/irq/<irq>/smp_affinity or smp_affinity_list files. When using
vfio to implement a device driver or a virtual machine monitor, this may
not be ideal: the process managing the vfio device interrupts may not be
granted root privilege, for security reasons. Thus it cannot directly
control the interrupt affinity and has to rely on an external command.

This patch extends the VFIO_DEVICE_SET_IRQS ioctl() with a new data flag
to specify the affinity of a vfio pci device interrupt.

The affinity argument must be a subset of the process cpuset, otherwise
an error -EPERM is returned.

The vfio_irq_set argument shall be set-up in the following way:

- the 'flags' field have the new flag VFIO_IRQ_SET_DATA_AFFINITY set
as well as VFIO_IRQ_SET_ACTION_TRIGGER.

- the 'start' field is the device interrupt index. Only one interrupt
can be configured per ioctl().

- the variable-length array consists of one or more CPU index
encoded as __u32, the number of entries in the array is specified in the
'count' field.

Fred Griffoul (2):
  cgroup/cpuset: export cpuset_cpus_allowed()
  vfio/pci: add interrupt affinity support

 arch/arm64/kernel/cpufeature.c    |  2 ++
 drivers/vfio/pci/vfio_pci_core.c  |  2 +-
 drivers/vfio/pci/vfio_pci_intrs.c | 41 +++++++++++++++++++++++++++++++
 drivers/vfio/vfio_main.c          | 20 ++++++++++++---
 include/uapi/linux/vfio.h         | 11 ++++++++-
 kernel/cgroup/cpuset.c            |  1 +
 6 files changed, 71 insertions(+), 6 deletions(-)


base-commit: cbb325e77fbe62a06184175aa98c9eb98736c3e8
--
2.40.1