mbox series

[0/2] KVM: x86/mmu: Clean up hugepage split error handling

Message ID 20240712151335.1242633-1-seanjc@google.com (mailing list archive)
Headers show
Series KVM: x86/mmu: Clean up hugepage split error handling | expand

Message

Sean Christopherson July 12, 2024, 3:13 p.m. UTC
"Fix" an impossible scenario where KVM would install a '0' SPTE instead of
using SHADOW_NONPRESENT_VALUE.  In quotes because (a) there's not truly anything
to fix (the code should never be hit), and (b) bugging the VM doesn't guarantee
KVM won't get confused (though it's still better than installing an empty SPTE).

The main motivation for this is to eliminate installing a '0' SPTE so that
future audits of the MMU don't complain about not using SHADOW_NONPRESENT_VALUE.

Sean Christopherson (2):
  KVM: x86/mmu: Bug the VM if KVM tries to split a !hugepage SPTE
  KVM: x86/mmu: Clean up make_huge_page_split_spte() definition and
    intro

 arch/x86/kvm/mmu/spte.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)


base-commit: 771df9ffadb8204e61d3e98f36c5067102aab78f

Comments

Paolo Bonzini July 16, 2024, 1:57 p.m. UTC | #1
Queued, thanks.

Paolo