| Message ID | 20241011021051.1557902-1-seanjc@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KVM: x86/mmu: A/D cleanups (on top of kvm_follow_pfn) | expand |
On 10/11/24 04:10, Sean Christopherson wrote: > This is effectively an extensive of the kvm_follow_pfn series[*] (and > applies on top of said series), but is x86-specific and is *almost* > entirely related to Accessed and Dirty bits. > > There's no central theme beyond cleaning up things that were discovered > when digging deep for the kvm_follow_pfn overhaul, and to a lesser extent > the series to add MGLRU support in KVM x86. Very nice - looks obvious in retrospect, as it often happens. Paolo > [*] https://lore.kernel.org/all/20241010182427.1434605-1-seanjc@google.com > > Sean Christopherson (18): > KVM: x86/mmu: Flush remote TLBs iff MMU-writable flag is cleared from > RO SPTE > KVM: x86/mmu: Always set SPTE's dirty bit if it's created as writable > KVM: x86/mmu: Fold all of make_spte()'s writable handling into one > if-else > KVM: x86/mmu: Don't force flush if SPTE update clears Accessed bit > KVM: x86/mmu: Don't flush TLBs when clearing Dirty bit in shadow MMU > KVM: x86/mmu: Drop ignored return value from > kvm_tdp_mmu_clear_dirty_slot() > KVM: x86/mmu: Fold mmu_spte_update_no_track() into mmu_spte_update() > KVM: x86/mmu: WARN and flush if resolving a TDP MMU fault clears > MMU-writable > KVM: x86/mmu: Add a dedicated flag to track if A/D bits are globally > enabled > KVM: x86/mmu: Set shadow_accessed_mask for EPT even if A/D bits > disabled > KVM: x86/mmu: Set shadow_dirty_mask for EPT even if A/D bits disabled > KVM: x86/mmu: Use Accessed bit even when _hardware_ A/D bits are > disabled > KVM: x86/mmu: Process only valid TDP MMU roots when aging a gfn range > KVM: x86/mmu: Stop processing TDP MMU roots for test_age if young SPTE > found > KVM: x86/mmu: Dedup logic for detecting TLB flushes on leaf SPTE > changes > KVM: x86/mmu: Set Dirty bit for new SPTEs, even if _hardware_ A/D bits > are disabled > KVM: Allow arch code to elide TLB flushes when aging a young page > KVM: x86: Don't emit TLB flushes when aging SPTEs for mmu_notifiers > > arch/x86/kvm/Kconfig | 1 + > arch/x86/kvm/mmu/mmu.c | 72 +++++++----------------- > arch/x86/kvm/mmu/spte.c | 59 ++++++++------------ > arch/x86/kvm/mmu/spte.h | 72 ++++++++++++------------ > arch/x86/kvm/mmu/tdp_mmu.c | 109 +++++++++++++++++-------------------- > arch/x86/kvm/mmu/tdp_mmu.h | 2 +- > virt/kvm/Kconfig | 4 ++ > virt/kvm/kvm_main.c | 20 ++----- > 8 files changed, 142 insertions(+), 197 deletions(-) > > > base-commit: 3f9cf3d569fdf7fb451294b636991291965573ce
On Thu, 10 Oct 2024 19:10:32 -0700, Sean Christopherson wrote: > This is effectively an extensive of the kvm_follow_pfn series[*] (and > applies on top of said series), but is x86-specific and is *almost* > entirely related to Accessed and Dirty bits. > > There's no central theme beyond cleaning up things that were discovered > when digging deep for the kvm_follow_pfn overhaul, and to a lesser extent > the series to add MGLRU support in KVM x86. > > [...] Applied to kvm-x86 mmu, with Paolo's suggestions (the guard(rcu) trick in particular was quite nice). [01/18] KVM: x86/mmu: Flush remote TLBs iff MMU-writable flag is cleared from RO SPTE https://github.com/kvm-x86/linux/commit/081976992f43 [02/18] KVM: x86/mmu: Always set SPTE's dirty bit if it's created as writable https://github.com/kvm-x86/linux/commit/cc7ed3358e41 [03/18] KVM: x86/mmu: Fold all of make_spte()'s writable handling into one if-else https://github.com/kvm-x86/linux/commit/0387d79e24d6 [04/18] KVM: x86/mmu: Don't force flush if SPTE update clears Accessed bit https://github.com/kvm-x86/linux/commit/b7ed46b201a4 [05/18] KVM: x86/mmu: Don't flush TLBs when clearing Dirty bit in shadow MMU https://github.com/kvm-x86/linux/commit/856cf4a60cff [06/18] KVM: x86/mmu: Drop ignored return value from kvm_tdp_mmu_clear_dirty_slot() https://github.com/kvm-x86/linux/commit/010344122dca [07/18] KVM: x86/mmu: Fold mmu_spte_update_no_track() into mmu_spte_update() https://github.com/kvm-x86/linux/commit/67c93802928b [08/18] KVM: x86/mmu: WARN and flush if resolving a TDP MMU fault clears MMU-writable https://github.com/kvm-x86/linux/commit/1a175082b190 [09/18] KVM: x86/mmu: Add a dedicated flag to track if A/D bits are globally enabled https://github.com/kvm-x86/linux/commit/a5da5dde4ba4 [10/18] KVM: x86/mmu: Set shadow_accessed_mask for EPT even if A/D bits disabled https://github.com/kvm-x86/linux/commit/3835819fb1b3 [11/18] KVM: x86/mmu: Set shadow_dirty_mask for EPT even if A/D bits disabled https://github.com/kvm-x86/linux/commit/53510b912518 [12/18] KVM: x86/mmu: Use Accessed bit even when _hardware_ A/D bits are disabled https://github.com/kvm-x86/linux/commit/7971801b5618 [13/18] KVM: x86/mmu: Process only valid TDP MMU roots when aging a gfn range https://github.com/kvm-x86/linux/commit/526e609f0567 [14/18] KVM: x86/mmu: Stop processing TDP MMU roots for test_age if young SPTE found https://github.com/kvm-x86/linux/commit/51192ebdd145 [15/18] KVM: x86/mmu: Dedup logic for detecting TLB flushes on leaf SPTE changes https://github.com/kvm-x86/linux/commit/c9b625625ba3 [16/18] KVM: x86/mmu: Set Dirty bit for new SPTEs, even if _hardware_ A/D bits are disabled https://github.com/kvm-x86/linux/commit/85649117511d [17/18] KVM: Allow arch code to elide TLB flushes when aging a young page https://github.com/kvm-x86/linux/commit/2ebbe0308c29 [18/18] KVM: x86: Don't emit TLB flushes when aging SPTEs for mmu_notifiers https://github.com/kvm-x86/linux/commit/b9883ee40d7e -- https://github.com/kvm-x86/linux/tree/next
This is effectively an extensive of the kvm_follow_pfn series[*] (and applies on top of said series), but is x86-specific and is *almost* entirely related to Accessed and Dirty bits. There's no central theme beyond cleaning up things that were discovered when digging deep for the kvm_follow_pfn overhaul, and to a lesser extent the series to add MGLRU support in KVM x86. [*] https://lore.kernel.org/all/20241010182427.1434605-1-seanjc@google.com Sean Christopherson (18): KVM: x86/mmu: Flush remote TLBs iff MMU-writable flag is cleared from RO SPTE KVM: x86/mmu: Always set SPTE's dirty bit if it's created as writable KVM: x86/mmu: Fold all of make_spte()'s writable handling into one if-else KVM: x86/mmu: Don't force flush if SPTE update clears Accessed bit KVM: x86/mmu: Don't flush TLBs when clearing Dirty bit in shadow MMU KVM: x86/mmu: Drop ignored return value from kvm_tdp_mmu_clear_dirty_slot() KVM: x86/mmu: Fold mmu_spte_update_no_track() into mmu_spte_update() KVM: x86/mmu: WARN and flush if resolving a TDP MMU fault clears MMU-writable KVM: x86/mmu: Add a dedicated flag to track if A/D bits are globally enabled KVM: x86/mmu: Set shadow_accessed_mask for EPT even if A/D bits disabled KVM: x86/mmu: Set shadow_dirty_mask for EPT even if A/D bits disabled KVM: x86/mmu: Use Accessed bit even when _hardware_ A/D bits are disabled KVM: x86/mmu: Process only valid TDP MMU roots when aging a gfn range KVM: x86/mmu: Stop processing TDP MMU roots for test_age if young SPTE found KVM: x86/mmu: Dedup logic for detecting TLB flushes on leaf SPTE changes KVM: x86/mmu: Set Dirty bit for new SPTEs, even if _hardware_ A/D bits are disabled KVM: Allow arch code to elide TLB flushes when aging a young page KVM: x86: Don't emit TLB flushes when aging SPTEs for mmu_notifiers arch/x86/kvm/Kconfig | 1 + arch/x86/kvm/mmu/mmu.c | 72 +++++++----------------- arch/x86/kvm/mmu/spte.c | 59 ++++++++------------ arch/x86/kvm/mmu/spte.h | 72 ++++++++++++------------ arch/x86/kvm/mmu/tdp_mmu.c | 109 +++++++++++++++++-------------------- arch/x86/kvm/mmu/tdp_mmu.h | 2 +- virt/kvm/Kconfig | 4 ++ virt/kvm/kvm_main.c | 20 ++----- 8 files changed, 142 insertions(+), 197 deletions(-) base-commit: 3f9cf3d569fdf7fb451294b636991291965573ce