From patchwork Mon Nov 18 17:20:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 13878893 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ED811C1738 for ; Mon, 18 Nov 2024 17:20:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731950406; cv=none; b=rLce3tJsrMVcwDpPCoI5SAnu0AdPsz50B4ygbAh9AqtoulymFZiKf7CvHalm6N6IIyP2oGKKtzTV770G5rzYa933kApMTQji6QDsZFQjgfkUBldP7j+/evTp/mBTAiwIQx1xZiGlulfYGlb8+k3is2QndtFgN7EvCfc3b5s4tz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731950406; c=relaxed/simple; bh=1jI3ULDI1a9rCFZ1Us9rWYeHRUMtPt4yMIsfQh9tk4c=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=Vw8hwsCDpzLoZbNaxfVH+9jfgKp5EvT4DlAC22BD489C+5ST217gL3WuXpg8JSHoY5Qa8Fo2JObBUDrzgmDMjEMZ2fm/69Y39TYLY2ts6NXs8B2G1uz25WcaV5jJ1ZRklPeOlEmd/rDS91yV2xPeXYq/w4pcBsn6MkNEk5Qupo0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=r6ealFvd; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="r6ealFvd" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-720e957722dso2540184b3a.2 for ; Mon, 18 Nov 2024 09:20:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731950404; x=1732555204; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=Ky6FJcmYTMi9G40huepN+3Su7qA9jw5okKykESK4qIM=; b=r6ealFvdosJAkxR5ZHcw3mjmmlzsMjEzwbvdw6gGWrwW1980Dki4o3nJ1sCtVZ4r0E vLTTFCdgk0UfOQTSz7xIkzRqQJcr7DW5qKNcxrDUen0IAMrjIULzyScQ64OVJgIH032S HAFVq57UbvJjGYKjbqfYVqcW46v2sNuEWfqkVMuLb2+gO3nQgnUmQATWdbh04bEAWBzF 0kvI+kK3uDFUR8QpL71SSbmrUwZ/Fdj6ADLlCxmoiIaiqv208q6lTfwc5lCWp5gw/41p VJHaAmNEeYR3ozQjLymNb9rKbKor02IdSL0yy34PwdgOMUHGQ2+JXegQswvtd6PT4YRM yh0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731950404; x=1732555204; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ky6FJcmYTMi9G40huepN+3Su7qA9jw5okKykESK4qIM=; b=jDvZYeCLIT05JRqrGc27JdStViP16xB/+hmBgbi75V+vlYwHdLQs4t8AtEE3be3/Bv NcR8mN6ZroAgUDh5g62e8Ncp6FkWIlSvcyE09rIevgLuF5dRU3bOOh9i2aOvi0/f8Hm9 LmDKMvWn7Y7bmYANWtiA07fgVUROOc+NfORyjGcbyRxAijIK1j978jCOrckF6aFWUfOx AfB8W4lIOJ7wDFpk4veF6Sdfn/V/VPFs/c6u21o2JmOpJZ4Ze8x4sb6NgHD/x/kfXBvi YarqU4UG1x0FsDpwFbRsMihZ2Z5I2YYPJz8S5l371lnC8PVcW/U4XL7NVZ30CE9ASiak OZ4g== X-Gm-Message-State: AOJu0YxX1dos4qCE6nFB+s+xhboYIjs6SbvWMNKJ/45myEjsY4ngputm m5wJ0HuHBz7OQlPA/GxGvJMC9iVOZL0j9KN+BQMpQRE1bwrq+1MapoTMewf4HQJ9o7wu0n3vN6W bPA== X-Google-Smtp-Source: AGHT+IHH4vEqXfWsqhCEybKMxEJ+7ogcipKSZwO5ZmC15IH6YH8dEDZmsqVnP2vj8hg0hg9+rNRlt61hcGo= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a05:6a00:234c:b0:720:b04d:8fcb with SMTP id d2e1a72fcca58-72476b84887mr152218b3a.1.1731950404700; Mon, 18 Nov 2024 09:20:04 -0800 (PST) Reply-To: Sean Christopherson Date: Mon, 18 Nov 2024 09:20:00 -0800 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog Message-ID: <20241118172002.1633824-1-seanjc@google.com> Subject: [PATCH 0/2] KVM: x86: Fix more KVM_X86 Kconfig bugs From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann Fix two more bugs in the KVM_X86 Kconfig. The fix from Arnd resolves a build failure, but practically speaking is a non-issue because the failure only affects 32-bit !SMP builds that effectively disable the local APIC. The second fix is far more urgent. It resolves a bug where KVM's Kconfig doesn't correctly define KVM_X86, and will build kvm.ko as a module when KVM=y if neither KVM_INTEL nor KVM_AMD is 'y', e.g. if KVM=y, KVM_INTEL,=m, and KVM_AMD=m. I don't know if any distros use that combo, but it broke our production kernel, so it's certainly possible that it broke other setups too. Arnd's fix was already posted, but I bundled it here to avoid a trivial conflict and to ensure it doesn't get left behind. Arnd Bergmann (1): KVM: x86: add back X86_LOCAL_APIC dependency Sean Christopherson (1): KVM: x86: Break CONFIG_KVM_X86's direct dependency on KVM_INTEL || KVM_AMD arch/x86/kvm/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: adc218676eef25575469234709c2d87185ca223a