mbox series

[kvm-unit-tests,v2,0/6] x86: LA57 canonical testcases

Message ID 20250215013018.1210432-1-seanjc@google.com (mailing list archive)
Headers show
Series x86: LA57 canonical testcases | expand

Message

Sean Christopherson Feb. 15, 2025, 1:30 a.m. UTC
v2 of Maxim's series to add testcases for canonical checks of various MSRs,
segment bases, and instructions that were found to ignore CR4.LA57 on CPUs
that support 5 level paging.

v2:
 - Fold into existing la57 test.
 - Always skip SYSENTER tests (they fail when run in a VM).
 - Lots of cosmetics cleanups (see v1 feedback for details).

v1: https://lore.kernel.org/all/20240907005440.500075-1-mlevitsk@redhat.com

Maxim Levitsky (5):
  x86: Add _safe() and _fep_safe() variants to segment base load
    instructions
  x86: Add a few functions for gdt manipulation
  x86: Move struct invpcid_desc descriptor to processor.h
  x86: Add testcases for writing (non)canonical LA57 values to MSRs and
    bases
  nVMX: add a test for canonical checks of various host state vmcs12
    fields.

Sean Christopherson (1):
  x86: Expand LA57 test to 64-bit mode (to prep for canonical testing)

 lib/x86/desc.c      |  38 ++++-
 lib/x86/desc.h      |   9 +-
 lib/x86/msr.h       |  42 ++++++
 lib/x86/processor.h |  58 +++++++-
 x86/Makefile.common |   3 +-
 x86/Makefile.i386   |   2 +-
 x86/la57.c          | 342 +++++++++++++++++++++++++++++++++++++++++++-
 x86/pcid.c          |   6 -
 x86/unittests.cfg   |   2 +-
 x86/vmx_tests.c     | 167 +++++++++++++++++++++
 10 files changed, 645 insertions(+), 24 deletions(-)


base-commit: f77fb696cfd0e4a5562cdca189be557946bf522f

Comments

Maxim Levitsky Feb. 19, 2025, 12:04 a.m. UTC | #1
On Fri, 2025-02-14 at 17:30 -0800, Sean Christopherson wrote:
> v2 of Maxim's series to add testcases for canonical checks of various MSRs,
> segment bases, and instructions that were found to ignore CR4.LA57 on CPUs
> that support 5 level paging.
> 
> v2:
>  - Fold into existing la57 test.
>  - Always skip SYSENTER tests (they fail when run in a VM).
>  - Lots of cosmetics cleanups (see v1 feedback for details).
> 
> v1: https://lore.kernel.org/all/20240907005440.500075-1-mlevitsk@redhat.com
> 
> Maxim Levitsky (5):
>   x86: Add _safe() and _fep_safe() variants to segment base load
>     instructions
>   x86: Add a few functions for gdt manipulation
>   x86: Move struct invpcid_desc descriptor to processor.h
>   x86: Add testcases for writing (non)canonical LA57 values to MSRs and
>     bases
>   nVMX: add a test for canonical checks of various host state vmcs12
>     fields.
> 
> Sean Christopherson (1):
>   x86: Expand LA57 test to 64-bit mode (to prep for canonical testing)
> 
>  lib/x86/desc.c      |  38 ++++-
>  lib/x86/desc.h      |   9 +-
>  lib/x86/msr.h       |  42 ++++++
>  lib/x86/processor.h |  58 +++++++-
>  x86/Makefile.common |   3 +-
>  x86/Makefile.i386   |   2 +-
>  x86/la57.c          | 342 +++++++++++++++++++++++++++++++++++++++++++-
>  x86/pcid.c          |   6 -
>  x86/unittests.cfg   |   2 +-
>  x86/vmx_tests.c     | 167 +++++++++++++++++++++
>  10 files changed, 645 insertions(+), 24 deletions(-)
> 
> 
> base-commit: f77fb696cfd0e4a5562cdca189be557946bf522f

Hi!
No major objections to any of the changes.

Can you also take a look at my other patch to kvm-unit-tests:

"pmu_lbr: drop check for MSR_LBR_TOS != 0"

Thanks,
Best regards,
	Maxim Levitsky