From patchwork Fri Sep 23 10:52:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hou Wenlong X-Patchwork-Id: 12986436 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F09ECAAD8 for ; Fri, 23 Sep 2022 10:52:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231403AbiIWKwi (ORCPT ); Fri, 23 Sep 2022 06:52:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231371AbiIWKw1 (ORCPT ); Fri, 23 Sep 2022 06:52:27 -0400 Received: from out0-137.mail.aliyun.com (out0-137.mail.aliyun.com [140.205.0.137]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54DC55053B for ; Fri, 23 Sep 2022 03:52:25 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018047190;MF=houwenlong.hwl@antgroup.com;NM=1;PH=DS;RN=2;SR=0;TI=SMTPD_---.PMYh3Yf_1663930342; Received: from localhost(mailfrom:houwenlong.hwl@antgroup.com fp:SMTPD_---.PMYh3Yf_1663930342) by smtp.aliyun-inc.com; Fri, 23 Sep 2022 18:52:23 +0800 From: "Hou Wenlong" To: kvm@vger.kernel.org Cc: David Matlack Subject: [PATCH v3 0/6] KVM: x86/mmu: Fix wrong usages of range-based tlb flushing Date: Fri, 23 Sep 2022 18:52:16 +0800 Message-Id: X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Commit c3134ce240eed ("KVM: Replace old tlb flush function with new one to flush a specified range.") replaces old tlb flush function with kvm_flush_remote_tlbs_with_address() to do tlb flushing. However, the gfn range of tlb flushing is wrong in some cases. E.g., when a spte is dropped, the start gfn of tlb flushing should be the gfn of spte not the base gfn of SP which contains the spte. Although, as Paolo said, Hyper-V may treat a 1-page flush the same if the address points to a huge page, and no fixes are reported so far. So it seems that it works well for Hyper-V. But it would be better to use the correct size for huge page. So this patchset would fix them and introduce some helper functions as David suggested to make the code clear. Changed from v2: - Introduce kvm_flush_remote_tlbs_gfn() in Patch 1 early. - Move round_gfn_for_level() in tdp_iter.c into mmu_internal.h for common usage and cleanup the call sites of rounding down the GFN. - Drop Patch 6. Changed from v1: - Align down gfn in kvm_set_pte_rmapp() instead of change iterator->gfn in rmap_walk_init_level() in Patch 2. - Introduce some helper functions for common operations as David suggested. v2: https://lore.kernel.org/kvm/cover.1661331396.git.houwenlong.hwl@antgroup.com Hou Wenlong (6): KVM: x86/mmu: Fix wrong gfn range of tlb flushing in validate_direct_spte() KVM: x86/mmu: Move round_gfn_for_level() helper into mmu_internal.h KVM: x86/mmu: Fix wrong gfn range of tlb flushing in kvm_set_pte_rmapp() KVM: x86/mmu: Reduce gfn range of tlb flushing in tdp_mmu_map_handle_target_level() KVM: x86/mmu: Fix wrong start gfn of tlb flushing with range KVM: x86/mmu: Cleanup range-based flushing for given page arch/x86/kvm/mmu/mmu.c | 43 +++++++++++++++++++++++---------- arch/x86/kvm/mmu/mmu_internal.h | 15 ++++++++++++ arch/x86/kvm/mmu/paging_tmpl.h | 5 ++-- arch/x86/kvm/mmu/tdp_iter.c | 11 +++------ arch/x86/kvm/mmu/tdp_mmu.c | 6 ++--- 5 files changed, 52 insertions(+), 28 deletions(-) --- 2.31.1