From patchwork Thu Aug 16 13:54:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 1332191 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 4BB70DFB34 for ; Thu, 16 Aug 2012 13:55:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932344Ab2HPNyv (ORCPT ); Thu, 16 Aug 2012 09:54:51 -0400 Received: from david.siemens.de ([192.35.17.14]:34185 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757077Ab2HPNyt (ORCPT ); Thu, 16 Aug 2012 09:54:49 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by david.siemens.de (8.13.6/8.13.6) with ESMTP id q7GDsYDc006991; Thu, 16 Aug 2012 15:54:34 +0200 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id q7GDsYJE012893; Thu, 16 Aug 2012 15:54:34 +0200 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Cc: kvm@vger.kernel.org, Alex Williamson Subject: [PATCH 04/19] pci-assign: Refactor interrupt deassignment Date: Thu, 16 Aug 2012 15:54:18 +0200 Message-Id: <107b5d2c581bac3d6ad87a9b9807d0273bd00f51.1345125266.git.jan.kiszka@siemens.com> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: References: In-Reply-To: References: Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Introduce three new KVM services, kvm_device_intx/msi/msix_deassign, to release assigned interrupts. These no longer require to pass pre-initialized kvm_assigned_irq structures but only request required parameters. To trace which type of interrupt is currently assigned, use a new enum AssignedIRQType instead of KVM constants. Signed-off-by: Jan Kiszka --- hw/device-assignment.c | 80 ++++++++++++++++++++++++++++++----------------- qemu-kvm.c | 5 --- qemu-kvm.h | 11 ------ target-i386/kvm.c | 29 +++++++++++++++++ target-i386/kvm_i386.h | 6 +++ 5 files changed, 86 insertions(+), 45 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index ee64c33..0b33c04 100644 --- a/hw/device-assignment.c +++ b/hw/device-assignment.c @@ -106,6 +106,14 @@ typedef struct { uint32_t ctrl; } MSIXTableEntry; +typedef enum AssignedIRQType { + ASSIGNED_IRQ_NONE = 0, + ASSIGNED_IRQ_INTX_HOST_INTX, + ASSIGNED_IRQ_INTX_HOST_MSI, + ASSIGNED_IRQ_MSI, + ASSIGNED_IRQ_MSIX +} AssignedIRQType; + typedef struct AssignedDevice { PCIDevice dev; PCIHostDeviceAddress host; @@ -117,7 +125,7 @@ typedef struct AssignedDevice { PCIDevRegions real_device; int run; PCIINTxRoute intx_route; - int irq_requested_type; + AssignedIRQType assigned_irq_type; int bound; struct { #define ASSIGNED_DEVICE_CAP_MSI (1 << 0) @@ -854,7 +862,9 @@ static int assign_device(AssignedDevice *dev) static int assign_intx(AssignedDevice *dev) { struct kvm_assigned_irq assigned_irq_data; + AssignedIRQType new_type; PCIINTxRoute intx_route; + bool intx_host_msi; int r = 0; /* Interrupt PIN 0 means don't use INTx */ @@ -874,17 +884,26 @@ static int assign_intx(AssignedDevice *dev) return r; } - memset(&assigned_irq_data, 0, sizeof(assigned_irq_data)); - assigned_irq_data.assigned_dev_id = dev->dev_id; - assigned_irq_data.guest_irq = intx_route.irq; - if (dev->irq_requested_type) { - assigned_irq_data.flags = dev->irq_requested_type; - r = kvm_deassign_irq(kvm_state, &assigned_irq_data); - if (r) { - perror("assign_intx: deassign"); - } - dev->irq_requested_type = 0; + switch (dev->assigned_irq_type) { + case ASSIGNED_IRQ_INTX_HOST_INTX: + case ASSIGNED_IRQ_INTX_HOST_MSI: + intx_host_msi = dev->assigned_irq_type == ASSIGNED_IRQ_INTX_HOST_MSI; + r = kvm_device_intx_deassign(kvm_state, dev->dev_id, intx_host_msi); + break; + case ASSIGNED_IRQ_MSI: + r = kvm_device_msi_deassign(kvm_state, dev->dev_id); + break; + case ASSIGNED_IRQ_MSIX: + r = kvm_device_msix_deassign(kvm_state, dev->dev_id); + break; + default: + r = 0; + break; } + if (r) { + perror("assign_intx: deassign"); + } + dev->assigned_irq_type = ASSIGNED_IRQ_NONE; if (intx_route.mode == PCI_INTX_DISABLED) { dev->intx_route = intx_route; @@ -892,12 +911,18 @@ static int assign_intx(AssignedDevice *dev) } retry: + memset(&assigned_irq_data, 0, sizeof(assigned_irq_data)); + assigned_irq_data.assigned_dev_id = dev->dev_id; + assigned_irq_data.guest_irq = intx_route.irq; assigned_irq_data.flags = KVM_DEV_IRQ_GUEST_INTX; if (dev->features & ASSIGNED_DEVICE_PREFER_MSI_MASK && - dev->cap.available & ASSIGNED_DEVICE_CAP_MSI) + dev->cap.available & ASSIGNED_DEVICE_CAP_MSI) { assigned_irq_data.flags |= KVM_DEV_IRQ_HOST_MSI; - else + new_type = ASSIGNED_IRQ_INTX_HOST_MSI; + } else { assigned_irq_data.flags |= KVM_DEV_IRQ_HOST_INTX; + new_type = ASSIGNED_IRQ_INTX_HOST_INTX; + } r = kvm_assign_irq(kvm_state, &assigned_irq_data); if (r < 0) { @@ -920,7 +945,7 @@ retry: } dev->intx_route = intx_route; - dev->irq_requested_type = assigned_irq_data.flags; + dev->assigned_irq_type = new_type; return r; } @@ -958,23 +983,19 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev) PCI_MSI_FLAGS); int r; - memset(&assigned_irq_data, 0, sizeof assigned_irq_data); - assigned_irq_data.assigned_dev_id = assigned_dev->dev_id; - /* Some guests gratuitously disable MSI even if they're not using it, * try to catch this by only deassigning irqs if the guest is using * MSI or intends to start. */ - if ((assigned_dev->irq_requested_type & KVM_DEV_IRQ_GUEST_MSI) || + if (assigned_dev->assigned_irq_type == ASSIGNED_IRQ_MSI || (ctrl_byte & PCI_MSI_FLAGS_ENABLE)) { - assigned_irq_data.flags = assigned_dev->irq_requested_type; free_dev_irq_entries(assigned_dev); - r = kvm_deassign_irq(kvm_state, &assigned_irq_data); + r = kvm_device_msi_deassign(kvm_state, assigned_dev->dev_id); /* -ENXIO means no assigned irq */ if (r && r != -ENXIO) perror("assigned_dev_update_msi: deassign irq"); - assigned_dev->irq_requested_type = 0; + assigned_dev->assigned_irq_type = ASSIGNED_IRQ_NONE; pci_device_set_intx_routing_notifier(pci_dev, NULL); } @@ -998,6 +1019,8 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev) kvm_irqchip_commit_routes(kvm_state); assigned_dev->irq_entries_nr = 1; + memset(&assigned_irq_data, 0, sizeof assigned_irq_data); + assigned_irq_data.assigned_dev_id = assigned_dev->dev_id; assigned_irq_data.guest_irq = assigned_dev->entry->gsi; assigned_irq_data.flags = KVM_DEV_IRQ_HOST_MSI | KVM_DEV_IRQ_GUEST_MSI; if (kvm_assign_irq(kvm_state, &assigned_irq_data) < 0) { @@ -1006,7 +1029,7 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev) assigned_dev->intx_route.mode = PCI_INTX_DISABLED; assigned_dev->intx_route.irq = -1; - assigned_dev->irq_requested_type = assigned_irq_data.flags; + assigned_dev->assigned_irq_type = ASSIGNED_IRQ_MSI; } else { assign_intx(assigned_dev); } @@ -1108,17 +1131,16 @@ static void assigned_dev_update_msix(PCIDevice *pci_dev) /* Some guests gratuitously disable MSIX even if they're not using it, * try to catch this by only deassigning irqs if the guest is using * MSIX or intends to start. */ - if ((assigned_dev->irq_requested_type & KVM_DEV_IRQ_GUEST_MSIX) || + if ((assigned_dev->assigned_irq_type == ASSIGNED_IRQ_MSIX) || (ctrl_word & PCI_MSIX_FLAGS_ENABLE)) { - assigned_irq_data.flags = assigned_dev->irq_requested_type; free_dev_irq_entries(assigned_dev); - r = kvm_deassign_irq(kvm_state, &assigned_irq_data); + r = kvm_device_msix_deassign(kvm_state, assigned_dev->dev_id); /* -ENXIO means no assigned irq */ if (r && r != -ENXIO) perror("assigned_dev_update_msix: deassign irq"); - assigned_dev->irq_requested_type = 0; + assigned_dev->assigned_irq_type = ASSIGNED_IRQ_NONE; pci_device_set_intx_routing_notifier(pci_dev, NULL); } @@ -1139,7 +1161,7 @@ static void assigned_dev_update_msix(PCIDevice *pci_dev) } assigned_dev->intx_route.mode = PCI_INTX_DISABLED; assigned_dev->intx_route.irq = -1; - assigned_dev->irq_requested_type = assigned_irq_data.flags; + assigned_dev->assigned_irq_type = ASSIGNED_IRQ_MSIX; } else { assign_intx(assigned_dev); } @@ -1655,14 +1677,14 @@ static void reset_assigned_device(DeviceState *dev) * enabled since it lives in MMIO space, which is about to get * disabled. */ - if (adev->irq_requested_type & KVM_DEV_IRQ_GUEST_MSIX) { + if (adev->assigned_irq_type == ASSIGNED_IRQ_MSIX) { uint16_t ctrl = pci_get_word(pci_dev->config + pci_dev->msix_cap + PCI_MSIX_FLAGS); pci_set_word(pci_dev->config + pci_dev->msix_cap + PCI_MSIX_FLAGS, ctrl & ~PCI_MSIX_FLAGS_ENABLE); assigned_dev_update_msix(pci_dev); - } else if (adev->irq_requested_type & KVM_DEV_IRQ_GUEST_MSI) { + } else if (adev->assigned_irq_type == ASSIGNED_IRQ_MSI) { uint8_t ctrl = pci_get_byte(pci_dev->config + pci_dev->msi_cap + PCI_MSI_FLAGS); diff --git a/qemu-kvm.c b/qemu-kvm.c index 7bf20d1..8bc9857 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -58,11 +58,6 @@ int kvm_assign_irq(KVMState *s, struct kvm_assigned_irq *assigned_irq) return kvm_old_assign_irq(s, assigned_irq); } - -int kvm_deassign_irq(KVMState *s, struct kvm_assigned_irq *assigned_irq) -{ - return kvm_vm_ioctl(s, KVM_DEASSIGN_DEV_IRQ, assigned_irq); -} #else int kvm_assign_irq(KVMState *s, struct kvm_assigned_irq *assigned_irq) { diff --git a/qemu-kvm.h b/qemu-kvm.h index 54e615a..1cdface 100644 --- a/qemu-kvm.h +++ b/qemu-kvm.h @@ -43,17 +43,6 @@ */ int kvm_assign_irq(KVMState *s, struct kvm_assigned_irq *assigned_irq); -/*! - * \brief Deassign IRQ for an assigned device - * - * Used for PCI device assignment, this function deassigns IRQ numbers - * for an assigned device. - * - * \param kvm Pointer to the current kvm_context - * \param assigned_irq Parameters, like dev id, host irq, guest irq, etc - */ -int kvm_deassign_irq(KVMState *s, struct kvm_assigned_irq *assigned_irq); - int kvm_device_intx_set_mask(KVMState *s, uint32_t dev_id, bool masked); struct kvm_irq_routing_entry; diff --git a/target-i386/kvm.c b/target-i386/kvm.c index f944f83..058ed3f 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -2091,3 +2091,32 @@ int kvm_device_pci_deassign(KVMState *s, uint32_t dev_id) return kvm_vm_ioctl(s, KVM_DEASSIGN_PCI_DEVICE, &dev_data); } + +static int kvm_deassign_irq_internal(KVMState *s, uint32_t dev_id, + uint32_t type) +{ + struct kvm_assigned_irq assigned_irq = { + .assigned_dev_id = dev_id, + .flags = type, + }; + + return kvm_vm_ioctl(s, KVM_DEASSIGN_DEV_IRQ, &assigned_irq); +} + +int kvm_device_intx_deassign(KVMState *s, uint32_t dev_id, bool use_host_msi) +{ + return kvm_deassign_irq_internal(s, dev_id, KVM_DEV_IRQ_GUEST_INTX | + (use_host_msi ? KVM_DEV_IRQ_HOST_MSI : KVM_DEV_IRQ_HOST_INTX)); +} + +int kvm_device_msi_deassign(KVMState *s, uint32_t dev_id) +{ + return kvm_deassign_irq_internal(s, dev_id, KVM_DEV_IRQ_GUEST_MSI | + KVM_DEV_IRQ_HOST_MSI); +} + +int kvm_device_msix_deassign(KVMState *s, uint32_t dev_id) +{ + return kvm_deassign_irq_internal(s, dev_id, KVM_DEV_IRQ_GUEST_MSIX | + KVM_DEV_IRQ_HOST_MSIX); +} diff --git a/target-i386/kvm_i386.h b/target-i386/kvm_i386.h index 5161f67..fdecdd5 100644 --- a/target-i386/kvm_i386.h +++ b/target-i386/kvm_i386.h @@ -19,4 +19,10 @@ int kvm_device_pci_assign(KVMState *s, PCIHostDeviceAddress *dev_addr, uint32_t flags, uint32_t *dev_id); int kvm_device_pci_deassign(KVMState *s, uint32_t dev_id); +int kvm_device_intx_deassign(KVMState *s, uint32_t dev_id, bool use_host_msi); + +int kvm_device_msi_deassign(KVMState *s, uint32_t dev_id); + +int kvm_device_msix_deassign(KVMState *s, uint32_t dev_id); + #endif