| Message ID | 1232726884-14747-1-git-send-email-agraf@suse.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
Alexander Graf wrote: > Most distributions use an executable name of qemu-kvm for kvm's > qemu version. > This is mostly because Qemu was there before and there usually is > a package with a binary called qemu-system-x86_64 already. > > In order to not confuse people why distributions do things so > differently from upstream, let's call the binary qemu-kvm in make > install, so it's always qemu-kvm. > > Inspired by Anthony. > While it does make sense, this will break a ton of existing scripts (and my testsuite...). Also, upsteam qemu also does not rename qemu even when kvm support is enabled.
Avi Kivity wrote: > Alexander Graf wrote: >> Most distributions use an executable name of qemu-kvm for kvm's >> qemu version. >> This is mostly because Qemu was there before and there usually is >> a package with a binary called qemu-system-x86_64 already. >> >> In order to not confuse people why distributions do things so >> differently from upstream, let's call the binary qemu-kvm in make >> install, so it's always qemu-kvm. >> >> Inspired by Anthony. >> > > While it does make sense, this will break a ton of existing scripts > (and my testsuite...). Also, upsteam qemu also does not rename qemu > even when kvm support is enabled. Wouldn't your scripts simply run qemu-system-x86_64 from the build directory? The patch only affects make install for exactly that reason. And at least from a distro perspective, symlinking qemu-kvm to qemu-system-x86_64 when things get stable in upstream qemu sounds fairly easy :-). Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
differently from upstream, let's call the binary qemu-kvm in make install, so it's always qemu-kvm. Inspired by Anthony. Signed-off-by: Alexander Graf <agraf@suse.de> --- qemu/Makefile.target | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/qemu/Makefile.target b/qemu/Makefile.target index 8f69af7..def3e2b 100644 --- a/qemu/Makefile.target +++ b/qemu/Makefile.target @@ -824,9 +824,13 @@ clean: rm -f *.d */*.d tcg/*.o install: all +ifeq ($(PROGS),qemu-system-x86_64) + $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)/qemu-kvm" +else ifneq ($(PROGS),) $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)" endif +endif # Include automatically generated dependency files -include $(wildcard *.d */*.d)