diff mbox

[1/1] kvm: fix irq 0 assignment

Message ID 1236066849-12515-1-git-send-email-sheng@linux.intel.com (mailing list archive)
State Superseded
Headers show

Commit Message

Sheng Yang March 3, 2009, 7:54 a.m. UTC 
Shouldn't update assigned irq if host irq is 0, which means uninitialized
or don't support INTx.

Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
 qemu/hw/device-assignment.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Comments

Sheng Yang March 3, 2009, 9:32 a.m. UTC | #1 
On Tuesday 03 March 2009 15:54:09 Sheng Yang wrote:
> Shouldn't update assigned irq if host irq is 0, which means uninitialized
> or don't support INTx.

Withdraw this, another problems shows...
Sheng Yang March 3, 2009, 10:40 a.m. UTC | #2 
On Tuesday 03 March 2009 17:32:13 Sheng Yang wrote:
> On Tuesday 03 March 2009 15:54:09 Sheng Yang wrote:
> > Shouldn't update assigned irq if host irq is 0, which means uninitialized
> > or don't support INTx.
>
> Withdraw this, another problems shows...

This one itself is OK, seems the problem caused by kernel side...
diff mbox

Patch

diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index b7cbcec..cfbf39d 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -521,6 +521,10 @@  static int assign_irq(AssignedDevInfo *adev)
     AssignedDevice *dev = adev->assigned_dev;
     int irq, r = 0;
 
+    /* irq 0 means uninitialized */
+    if (dev->real_device.irq == 0)
+        return 0;
+
     irq = pci_map_irq(&dev->dev, dev->intpin);
     irq = piix_get_irq(irq);