From patchwork Thu Apr 9 01:40:59 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sheng Yang X-Patchwork-Id: 17294 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n391f9D5015227 for ; Thu, 9 Apr 2009 01:41:09 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751620AbZDIBlG (ORCPT ); Wed, 8 Apr 2009 21:41:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752380AbZDIBlF (ORCPT ); Wed, 8 Apr 2009 21:41:05 -0400 Received: from mga09.intel.com ([134.134.136.24]:48889 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbZDIBlE (ORCPT ); Wed, 8 Apr 2009 21:41:04 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 08 Apr 2009 18:32:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.40,157,1239001200"; d="scan'208";a="504876272" Received: from syang10-desktop.sh.intel.com (HELO syang10-desktop) ([10.239.13.189]) by orsmga001.jf.intel.com with ESMTP; 08 Apr 2009 18:40:28 -0700 Received: from yasker by syang10-desktop with local (Exim 4.69) (envelope-from ) id 1LrjGF-00061i-Dq; Thu, 09 Apr 2009 09:40:59 +0800 From: Sheng Yang To: Avi Kivity Cc: kvm@vger.kernel.org, Alex Williamson , Sheng Yang Subject: [PATCH 1/1] kvm: don't check per-vector mask bit before enable MSI-X Date: Thu, 9 Apr 2009 09:40:59 +0800 Message-Id: <1239241259-23146-1-git-send-email-sheng@linux.intel.com> X-Mailer: git-send-email 1.5.6.3 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Some driver(e.g. bnx2) do the following to enable MSI-X: 1. Mask all vectors. 2. Write the msg data and address. 3. Enable MSI-X 4. Unmask all the vectors. For this, check per-vector mask bit before enable MSI-X would cause device fail to enable MSI-X. So now we only determine the availability of vector by if msg_data is zero. Signed-off-by: Sheng Yang --- qemu/hw/device-assignment.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c index f33ce3c..1f0a1a7 100644 --- a/qemu/hw/device-assignment.c +++ b/qemu/hw/device-assignment.c @@ -823,9 +823,6 @@ static int assigned_dev_update_msix_mmio(PCIDevice *pci_dev) /* Get the usable entry number for allocating */ for (i = 0; i < entries_max_nr; i++) { memcpy(&msg_ctrl, va + i * 16 + 12, 4); - /* 0x1 is mask bit for per vector */ - if (msg_ctrl & 0x1) - continue; memcpy(&msg_data, va + i * 16 + 8, 4); /* Ignore unused entry even it's unmasked */ if (msg_data == 0)