From patchwork Wed May 27 00:40:14 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucas Meneghel Rodrigues X-Patchwork-Id: 26283 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4R0eNvm011980 for ; Wed, 27 May 2009 00:40:23 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755416AbZE0AkS (ORCPT ); Tue, 26 May 2009 20:40:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755204AbZE0AkR (ORCPT ); Tue, 26 May 2009 20:40:17 -0400 Received: from mx2.redhat.com ([66.187.237.31]:50950 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754784AbZE0AkQ (ORCPT ); Tue, 26 May 2009 20:40:16 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4R0eImR017712 for ; Tue, 26 May 2009 20:40:18 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4R0eHoR023569 for ; Tue, 26 May 2009 20:40:18 -0400 Received: from [10.11.12.241] (vpn-12-241.rdu.redhat.com [10.11.12.241]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4R0eFIB023651 for ; Tue, 26 May 2009 20:40:17 -0400 Subject: [PATCH + RFC] Cascading option --with-kvm-trace to qemu configure script From: Lucas Meneghel Rodrigues To: KVM mailing list Date: Tue, 26 May 2009 21:40:14 -0300 Message-Id: <1243384814.2858.55.camel@localhost.localdomain> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org We've found a build issue on release tarballs: if we take a recent release tarball, build it using the usual sequence ./configure make make install The modules generated can't be loaded due to unresolved symbols related to kvm trace. While fixing the problem, we noticed that is not possible to pass the --with-kvm-trace option to the main qemu configure script. This patch makes it possible to cascade --with-kvm-trace option from the qemu toplevel configure script to the KVM kernel configure script. It is our understanding that this cascading is desirable, however we are not completely sure about it, hence we are asking for comments on this change. The actual fix for the issue we found will follow, however the patches are independant. Signed-off-by: Lucas Meneghel Rodrigues --- configure 2009-05-19 13:29:02.000000000 -0300 +++ ../configure.backup 2009-05-26 21:16:53.702104650 -0300 @@ -198,6 +198,7 @@ mixemu="no" bluez="yes" kvm="yes" +kvm_trace="no" kvm_cap_pit="no" kvm_cap_device_assignment="no" kerneldir="" @@ -521,6 +522,8 @@ ;; --kerneldir=*) kerneldir="$optarg" ;; + --with-kvm-trace) kvm_trace="yes" + ;; --with-pkgversion=*) pkgversion=" ($optarg)" ;; --disable-cpu-emulation) cpu_emulation="no" @@ -656,6 +659,7 @@ echo " --enable-io-thread enable IO thread" echo " --disable-blobs disable installing provided firmware blobs" echo " --kerneldir=PATH look for kernel includes in PATH" +echo " --with-kvm-trace enable building the KVM module with the kvm trace option" echo " --disable-cpu-emulation disables use of qemu cpu emulation code" echo "" echo "NOTE: The object files are built at the place where configure is launched" @@ -1402,7 +1406,10 @@ kvm_kmod="yes" kmod_args="" if test -n "$kerneldir"; then - kmod_args="--kerneldir=$kerneldir" + kmod_args="--kerneldir=$kerneldir" + fi + if test "$kvm_trace" = "yes"; then + kmod_args="$kmod_args --with-kvm-trace" fi # hope there are no spaces in kmod_args; can't use arrays because of # dash. @@ -1470,6 +1477,7 @@ echo "IO thread $io_thread" echo "Install blobs $blobs" echo "KVM support $kvm" +echo "KVM trace support $kvm_trace" echo "fdt support $fdt" echo "preadv support $preadv"