From patchwork Mon Jun 1 13:22:01 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Avi Kivity X-Patchwork-Id: 27197 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n51DMK4i018739 for ; Mon, 1 Jun 2009 13:22:20 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755090AbZFANWL (ORCPT ); Mon, 1 Jun 2009 09:22:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757547AbZFANWL (ORCPT ); Mon, 1 Jun 2009 09:22:11 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58766 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757415AbZFANWG (ORCPT ); Mon, 1 Jun 2009 09:22:06 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n51DM70C021177; Mon, 1 Jun 2009 09:22:07 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n51DM6I6019912; Mon, 1 Jun 2009 09:22:06 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n51DM4aZ003947; Mon, 1 Jun 2009 09:22:05 -0400 Received: from localhost.localdomain (cleopatra.tlv.redhat.com [10.35.255.11]) by cleopatra.tlv.redhat.com (Postfix) with ESMTP id 7F5C8250AC0; Mon, 1 Jun 2009 16:22:04 +0300 (IDT) From: Avi Kivity To: kvm@vger.kernel.org Cc: Marcelo Tosatti , Joerg Roedel , Sheng Yang Subject: [PATCH 1/3] KVM: VMX: Avoid duplicate ept tlb flush when setting cr3 Date: Mon, 1 Jun 2009 16:22:01 +0300 Message-Id: <1243862524-22120-2-git-send-email-avi@redhat.com> In-Reply-To: <1243862524-22120-1-git-send-email-avi@redhat.com> References: <1243862524-22120-1-git-send-email-avi@redhat.com> X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org vmx_set_cr3() will call vmx_tlb_flush(), which will flush the ept context. So there is no need to call ept_sync_context() explicitly. Signed-off-by: Avi Kivity --- arch/x86/kvm/vmx.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 25f1239..5607de8 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -1642,7 +1642,6 @@ static void vmx_set_cr3(struct kvm_vcpu *vcpu, unsigned long cr3) if (enable_ept) { eptp = construct_eptp(cr3); vmcs_write64(EPT_POINTER, eptp); - ept_sync_context(eptp); ept_load_pdptrs(vcpu); guest_cr3 = is_paging(vcpu) ? vcpu->arch.cr3 : VMX_EPT_IDENTITY_PAGETABLE_ADDR;