From patchwork Wed Jun 3 21:19:30 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Glauber Costa X-Patchwork-Id: 27739 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n53LJrWE011560 for ; Wed, 3 Jun 2009 21:19:54 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755200AbZFCVTg (ORCPT ); Wed, 3 Jun 2009 17:19:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754585AbZFCVTf (ORCPT ); Wed, 3 Jun 2009 17:19:35 -0400 Received: from mx2.redhat.com ([66.187.237.31]:38135 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755200AbZFCVTb (ORCPT ); Wed, 3 Jun 2009 17:19:31 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n53LJXM0008286 for ; Wed, 3 Jun 2009 17:19:33 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n53LJWxU001493; Wed, 3 Jun 2009 17:19:33 -0400 Received: from localhost.localdomain (virtlab1.virt.bos.redhat.com [10.16.72.21]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n53LJUTW025663; Wed, 3 Jun 2009 17:19:32 -0400 From: Glauber Costa To: kvm@vger.kernel.org Cc: avi@redhat.com Subject: [PATCH 4/4] provide a kvm-free implementation of ioapic Date: Wed, 3 Jun 2009 17:19:30 -0400 Message-Id: <1244063970-13913-5-git-send-email-glommer@redhat.com> In-Reply-To: <1244063970-13913-4-git-send-email-glommer@redhat.com> References: <1244063970-13913-1-git-send-email-glommer@redhat.com> <1244063970-13913-2-git-send-email-glommer@redhat.com> <1244063970-13913-3-git-send-email-glommer@redhat.com> <1244063970-13913-4-git-send-email-glommer@redhat.com> X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Also, provide a kvm_ioapic that does not depend highly on common code. Signed-off-by: Glauber Costa --- hw/ioapic.c | 162 +++++++++++++++++++++++++++++++++++++--------------------- hw/pc.c | 7 ++- hw/pc.h | 1 + 3 files changed, 110 insertions(+), 60 deletions(-) diff --git a/hw/ioapic.c b/hw/ioapic.c index 6c178c7..3eb5d5f 100644 --- a/hw/ioapic.c +++ b/hw/ioapic.c @@ -198,58 +198,11 @@ static void ioapic_mem_writel(void *opaque, target_phys_addr_t addr, uint32_t va } } -static void kvm_kernel_ioapic_save_to_user(IOAPICState *s) -{ -#if defined(KVM_CAP_IRQCHIP) && defined(TARGET_I386) - struct kvm_irqchip chip; - struct kvm_ioapic_state *kioapic; - int i; - - chip.chip_id = KVM_IRQCHIP_IOAPIC; - kvm_get_irqchip(kvm_context, &chip); - kioapic = &chip.chip.ioapic; - - s->id = kioapic->id; - s->ioregsel = kioapic->ioregsel; - s->base_address = kioapic->base_address; - s->irr = kioapic->irr; - for (i = 0; i < IOAPIC_NUM_PINS; i++) { - s->ioredtbl[i] = kioapic->redirtbl[i].bits; - } -#endif -} - -static void kvm_kernel_ioapic_load_from_user(IOAPICState *s) -{ -#if defined(KVM_CAP_IRQCHIP) && defined(TARGET_I386) - struct kvm_irqchip chip; - struct kvm_ioapic_state *kioapic; - int i; - - chip.chip_id = KVM_IRQCHIP_IOAPIC; - kioapic = &chip.chip.ioapic; - - kioapic->id = s->id; - kioapic->ioregsel = s->ioregsel; - kioapic->base_address = s->base_address; - kioapic->irr = s->irr; - for (i = 0; i < IOAPIC_NUM_PINS; i++) { - kioapic->redirtbl[i].bits = s->ioredtbl[i]; - } - - kvm_set_irqchip(kvm_context, &chip); -#endif -} - -static void ioapic_save(QEMUFile *f, void *opaque) +static void ioapic_save_common(QEMUFile *f, void *opaque) { IOAPICState *s = opaque; int i; - if (kvm_enabled() && qemu_kvm_irqchip_in_kernel()) { - kvm_kernel_ioapic_save_to_user(s); - } - qemu_put_8s(f, &s->id); qemu_put_8s(f, &s->ioregsel); qemu_put_be64s(f, &s->base_address); @@ -259,7 +212,12 @@ static void ioapic_save(QEMUFile *f, void *opaque) } } -static int ioapic_load(QEMUFile *f, void *opaque, int version_id) +static void ioapic_save(QEMUFile *f, void *opaque) +{ + ioapic_save_common(f, opaque); +} + +static int ioapic_load_common(QEMUFile *f, void *opaque, int version_id) { IOAPICState *s = opaque; int i; @@ -283,14 +241,15 @@ static int ioapic_load(QEMUFile *f, void *opaque, int version_id) qemu_get_be64s(f, &s->ioredtbl[i]); } - if (kvm_enabled() && qemu_kvm_irqchip_in_kernel()) { - kvm_kernel_ioapic_load_from_user(s); - } - return 0; } -static void ioapic_reset(void *opaque) +static int ioapic_load(QEMUFile *f, void *opaque, int version_id) +{ + return ioapic_load_common(f, opaque, version_id); +} + +static void ioapic_reset_common(void *opaque) { IOAPICState *s = opaque; int i; @@ -299,11 +258,11 @@ static void ioapic_reset(void *opaque) s->base_address = IOAPIC_DEFAULT_BASE_ADDRESS; for(i = 0; i < IOAPIC_NUM_PINS; i++) s->ioredtbl[i] = 1 << 16; /* mask LVT */ -#ifdef KVM_CAP_IRQCHIP - if (kvm_enabled() && qemu_kvm_irqchip_in_kernel()) { - kvm_kernel_ioapic_load_from_user(s); - } -#endif +} + +static void ioapic_reset(void *opaque) +{ + ioapic_reset_common(opaque); } static CPUReadMemoryFunc *ioapic_mem_read[3] = { @@ -335,3 +294,88 @@ IOAPICState *ioapic_init(void) return s; } + +#ifdef KVM_CAP_IRQCHIP +static void kvm_kernel_ioapic_save_to_user(IOAPICState *s) +{ +#if defined(TARGET_I386) + struct kvm_irqchip chip; + struct kvm_ioapic_state *kioapic; + int i; + + chip.chip_id = KVM_IRQCHIP_IOAPIC; + kvm_get_irqchip(kvm_context, &chip); + kioapic = &chip.chip.ioapic; + + s->id = kioapic->id; + s->ioregsel = kioapic->ioregsel; + s->base_address = kioapic->base_address; + s->irr = kioapic->irr; + for (i = 0; i < IOAPIC_NUM_PINS; i++) { + s->ioredtbl[i] = kioapic->redirtbl[i].bits; + } +#endif +} + +static void kvm_kernel_ioapic_load_from_user(IOAPICState *s) +{ +#if defined(TARGET_I386) + struct kvm_irqchip chip; + struct kvm_ioapic_state *kioapic; + int i; + + chip.chip_id = KVM_IRQCHIP_IOAPIC; + kioapic = &chip.chip.ioapic; + + kioapic->id = s->id; + kioapic->ioregsel = s->ioregsel; + kioapic->base_address = s->base_address; + kioapic->irr = s->irr; + for (i = 0; i < IOAPIC_NUM_PINS; i++) { + kioapic->redirtbl[i].bits = s->ioredtbl[i]; + } + + kvm_set_irqchip(kvm_context, &chip); +#endif +} + +static void kvm_ioapic_save(QEMUFile *f, void *opaque) +{ + IOAPICState *s = opaque; + kvm_kernel_ioapic_save_to_user(s); + + ioapic_save_common(f, opaque); +} + +static int kvm_ioapic_load(QEMUFile *f, void *opaque, int version_id) +{ + IOAPICState *s = opaque; + int r = ioapic_load_common(f, opaque, version_id); + + if (r == 0) + kvm_kernel_ioapic_load_from_user(s); + return r; +} + + +static void kvm_ioapic_reset(void *opaque) +{ + IOAPICState *s = opaque; + + ioapic_reset_common(opaque); + + kvm_kernel_ioapic_load_from_user(s); +} + +IOAPICState *kvm_ioapic_init(void) +{ + IOAPICState *s; + + s = qemu_mallocz(sizeof(IOAPICState)); + kvm_ioapic_reset(s); + + register_savevm("ioapic", 0, 2, kvm_ioapic_save, kvm_ioapic_load, s); + qemu_register_reset(kvm_ioapic_reset, 0, s); + return s; +} +#endif diff --git a/hw/pc.c b/hw/pc.c index a99ab07..861dc34 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -1042,7 +1042,12 @@ static void pc_init1(ram_addr_t ram_size, register_ioport_write(0x92, 1, 1, ioport92_write, NULL); if (pci_enabled) { - ioapic = ioapic_init(); +#ifdef KVM_CAP_IRQCHIP + if (kvm_enabled() && qemu_kvm_irqchip_in_kernel()) + ioapic = kvm_ioapic_init(); + else +#endif + ioapic = ioapic_init(); } #ifdef USE_KVM_PIT if (kvm_enabled() && qemu_kvm_pit_in_kernel()) diff --git a/hw/pc.h b/hw/pc.h index ab847b9..d7f4a46 100644 --- a/hw/pc.h +++ b/hw/pc.h @@ -53,6 +53,7 @@ int apic_accept_pic_intr(CPUState *env); void apic_deliver_pic_intr(CPUState *env, int level); int apic_get_interrupt(CPUState *env); IOAPICState *ioapic_init(void); +IOAPICState *kvm_ioapic_init(void); void ioapic_set_irq(void *opaque, int vector, int level); void apic_reset_irq_delivered(void); int apic_get_irq_delivered(void);