From patchwork Tue Jul 21 23:57:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Glauber Costa X-Patchwork-Id: 36661 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n6LNvXXi016466 for ; Tue, 21 Jul 2009 23:57:33 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750844AbZGUX52 (ORCPT ); Tue, 21 Jul 2009 19:57:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750923AbZGUX52 (ORCPT ); Tue, 21 Jul 2009 19:57:28 -0400 Received: from mx2.redhat.com ([66.187.237.31]:49389 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbZGUX52 (ORCPT ); Tue, 21 Jul 2009 19:57:28 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6LNvRko016647 for ; Tue, 21 Jul 2009 19:57:27 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n6LNvQMw003845; Tue, 21 Jul 2009 19:57:27 -0400 Received: from localhost.localdomain (virtlab1.virt.bos.redhat.com [10.16.72.21]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n6LNvQW4027012; Tue, 21 Jul 2009 19:57:26 -0400 From: Glauber Costa To: kvm@vger.kernel.org Cc: avi@redhat.com Subject: [PATCH] fix serious regression Date: Tue, 21 Jul 2009 19:57:26 -0400 Message-Id: <1248220646-22129-1-git-send-email-glommer@redhat.com> X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Today I found a very catastrophic regression: I cannot run my mission critical servers running RHL7.1 anymore. This is a total disaster. Fortunately, I was able to isolate the commit that caused it: commit bb598da496c040d42dde564bd8ace181be52293e Author: Glauber Costa Date: Mon Jul 6 16:12:52 2009 -0400 This guy is certainly stupid, and deserves punishment. It means I'll be writting code using emacs for the next week. Marcelo, please apply Signed-off-by: Glauber Costa --- qemu-kvm.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index e200dea..393c5cc 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -1003,8 +1003,6 @@ int pre_kvm_run(kvm_context_t kvm, CPUState *env) { kvm_arch_pre_kvm_run(kvm->opaque, env); - if (env->exit_request) - return 1; pthread_mutex_unlock(&qemu_mutex); return 0; }